Skip to content

Commit

Permalink
Merge branch 'dev'
Browse files Browse the repository at this point in the history
  • Loading branch information
adireddy committed Mar 4, 2016
2 parents 61e236f + 446da34 commit 171a31f
Show file tree
Hide file tree
Showing 121 changed files with 3,426 additions and 1,546 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*.zip
*.hxproj
.haxelib/
.out/

check-style-report.json
check-style-report.xml
check-style-report.xml
6 changes: 5 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ git:
depth: 1

language: haxe
os:
- linux
- osx
haxe:
- "3.2.1"
- development
hxml:
- build.hxml
sudo: false
sudo: false
36 changes: 36 additions & 0 deletions LIMITATIONS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
##Limitations of checkstyle checks

checkstyle has three types of checks:

1. line based
2. token based
3. AST based

Which check uses what type is not instantly clear to the user.

###line based checks
* scan files line by line
* usually applies a regex to each line
* tries to detect line separator by finding first occurrence of \r, \n or \r\n
* supports all features of Haxe
* can work with files that won't compile

###token based checks
* relies on HaxeLexer from haxeparser library
* uses work in progress version of token tree builder
- might build incomplete / incorrect tree structure resulting in false positives / negatives
- might result in endless loops or stacktraces
- can be turned off, by not using token tree based checks (excluding them via config.json)
* has position information for all nodes
* access to parent and child nodes
* should support all features of Haxe
* easy search and filter for specific node types
* can work with files that won't compile (limited)

###AST based checks
* relies on HaxeParser from haxeparser library
* partial support for #if, #else, #elseif (only active conditionals)
* macro support unclear (needs to be confirmed / checked)
* no parent info for a given Expr or ComplexType
* position info available only for a subset of all AST nodes
* files must compile
7 changes: 4 additions & 3 deletions build.hxml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@

--next

-cp resources
-cp checkstyle
-cp src
-lib haxeparser
-lib compiletime
-lib hxargs
Expand All @@ -16,12 +15,14 @@
-main checkstyle.Main
-D checkstyle
-neko run.n
-cmd neko run -s checkstyle -p resources/static-analysis.xml -report

--next
-main checkstyle.Main
-neko run.n

--next
-cmd neko run -s src -p resources/static-analysis.xml -report

--next
-cp test
-main TestMain
Expand Down
22 changes: 22 additions & 0 deletions buildTelemetry.hxml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
-cmd haxelib newrepo
-cmd haxelib install haxeparser 3.2.0 || true
-cmd haxelib install compiletime 2.6.0 || true
-cmd haxelib install hxargs 3.0.0 || true
-cmd haxelib install hxtelemetry 0.3.3 || true

--next

-cp resources
-cp src
-lib haxeparser
-lib compiletime
-lib hxargs
-lib hxtelemetry

--each

-D HXCPP_STACK_TRACE
-D HXCPP_TELEMETRY

-main checkstyle.Main
-cpp out
70 changes: 0 additions & 70 deletions checkstyle/checks/BlockFormatCheck.hx

This file was deleted.

Loading

0 comments on commit 171a31f

Please sign in to comment.