Remove unused imports and variables (#289)

(reported by Haxe 3.3.0 / vshaxe)

src/checkstyle/Checker.hx

@@ -104,14 +104,11 @@ class Checker {
 
 	function makeLines() {
 		var code = file.content;
-		var left = false;
-		var s = 0;
 		lines = code.split(lineSeparator);
 	}
 
 	function makeTokens() {
 		try {
-			var code = file.content;
 			tokens = [];
 			tokenTree = null;
 			var lexer = new HaxeLexer(bytes, file.name);

src/checkstyle/Main.hx

@@ -18,7 +18,6 @@ import sys.FileSystem;
 import sys.io.File;
 
 using checkstyle.utils.ArrayUtils;
-using checkstyle.utils.StringUtils;
 
 class Main {
 

src/checkstyle/checks/Check.hx

@@ -1,9 +1,7 @@
 package checkstyle.checks;
 
-import haxe.macro.Expr.Position;
 import haxe.macro.Expr;
 import checkstyle.CheckMessage.SeverityLevel;
-import haxeparser.Data;
 
 #if debug
 import haxe.CallStack;

src/checkstyle/checks/block/EmptyBlockCheck.hx

@@ -1,8 +1,6 @@
 package checkstyle.checks.block;
 
 import checkstyle.token.TokenTree;
-import haxeparser.Data;
-import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;
 

src/checkstyle/checks/block/LeftCurlyCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.block;
 
 import checkstyle.token.TokenTree;
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;
@@ -170,8 +169,6 @@ class LeftCurlyCheck extends Check {
 	}
 
 	function checkLeftCurly(line:String, wrapped:Bool = false, pos:Position) {
-		var lineLength:Int = line.length;
-
 		// must have at least one non whitespace character before curly
 		// and only whitespace, /* + comment or // + comment after curly
 		var curlyAtEOL:Bool = ~/^\s*\S.*\{\s*(|\/\*.*|\/\/.*)$/.match(line);

src/checkstyle/checks/block/NeedBracesCheck.hx

@@ -3,7 +3,6 @@ package checkstyle.checks.block;
 import checkstyle.Checker.LinePos;
 import checkstyle.token.TokenTree;
 import haxeparser.Data;
-import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;
 

src/checkstyle/checks/block/RightCurlyCheck.hx

@@ -2,7 +2,6 @@ package checkstyle.checks.block;
 
 import checkstyle.Checker.LinePos;
 import checkstyle.token.TokenTree;
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;

src/checkstyle/checks/coding/HiddenFieldCheck.hx

@@ -1,10 +1,8 @@
 package checkstyle.checks.coding;
 
 import checkstyle.token.TokenTree;
-import haxeparser.Data.TokenDef;
 
 using checkstyle.utils.ArrayUtils;
-using checkstyle.utils.FieldUtils;
 
 @name("HiddenField")
 @desc("Checks that a local variable or a parameter does not shadow a field that is defined in the same class.")

src/checkstyle/checks/coding/InnerAssignmentCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.coding;
 
 import checkstyle.token.TokenTree;
-import haxe.macro.Expr;
 import haxeparser.Data.TokenDef;
 
 @name("InnerAssignment")
@@ -32,7 +31,6 @@ class InnerAssignmentCheck extends Check {
 			Binop(OpAssignOp(OpOr)),
 			Binop(OpAssignOp(OpXor))
 		], ALL);
-		var x:Int = 0;
 		for (assignToken in allAssignments) {
 			if (isPosSuppressed(assignToken.pos) || !filterAssignment(assignToken)) continue;
 			logPos("Inner assignment detected", assignToken.pos);

src/checkstyle/checks/coding/NestedForDepthCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.coding;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 @name("NestedForDepth")

src/checkstyle/checks/coding/NestedIfDepthCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.coding;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 @name("NestedIfDepth")

src/checkstyle/checks/coding/NestedTryDepthCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.coding;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 @name("NestedTryDepth")

src/checkstyle/checks/coding/SimplifyBooleanExpressionCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.coding;
 
 import checkstyle.token.TokenTree;
-import haxe.macro.Expr;
 
 @name("SimplifyBooleanExpression")
 @desc("Checks for over-complicated boolean expressions. Finds code like `if (b == true), b || true, !false`, etc.")

src/checkstyle/checks/coding/VariableInitialisationCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.coding;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;

src/checkstyle/checks/comments/TODOCommentCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.comments;
 
 import checkstyle.CheckMessage.SeverityLevel;
-import haxeparser.Data.Token;
 
 @name("TODOComment")
 @desc("A check for TODO/FIXME/HACK/XXX/BUG comments. The format can be customised by changing `format` property.")

src/checkstyle/checks/imports/AvoidStarImportCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.imports;
 
 import checkstyle.token.TokenTree;
-import haxe.macro.Expr;
 
 @name("AvoidStarImport")
 @desc("Checks for import statements that use the * notation and using directives.")

src/checkstyle/checks/imports/UnusedImportCheck.hx

@@ -2,8 +2,6 @@ package checkstyle.checks.imports;
 
 import checkstyle.token.TokenTree;
 import checkstyle.utils.TokenTreeCheckUtils;
-import haxe.macro.Expr;
-import haxe.macro.Expr;
 import haxe.io.Path;
 import haxeparser.Data;
 
@@ -93,7 +91,6 @@ class UnusedImportCheck extends Check {
 	function detectModuleName(token:TokenTree):String {
 		var moduleName:StringBuf = new StringBuf();
 
-		var copy:Bool = false;
 		while (true) {
 			switch (token.tok) {
 				case Binop(OpMult): return null;

src/checkstyle/checks/literal/MultipleStringLiteralsCheck.hx

@@ -3,7 +3,6 @@ package checkstyle.checks.literal;
 import checkstyle.token.TokenTree;
 import checkstyle.token.TokenTreeBuilder;
 import checkstyle.utils.StringUtils;
-import haxe.macro.Expr;
 
 @name("MultipleStringLiterals")
 @desc("Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.")

src/checkstyle/checks/literal/StringLiteralCheck.hx

@@ -22,7 +22,6 @@ class StringLiteralCheck extends Check {
 	override function actualRun() {
 		var root:TokenTree = TokenTreeBuilder.buildTokenTree(checker.tokens, checker.bytes);
 
-		var allLiterals:Map<String, Int> = new Map<String, Int>();
 		var allStringLiterals:Array<TokenTree> = root.filterCallback(function(token:TokenTree, depth:Int):FilterResult {
 			if (token.tok == null) return GO_DEEPER;
 			return switch (token.tok) {

src/checkstyle/checks/modifier/ModifierOrderCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.modifier;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 @name("ModifierOrder", "AccessOrder")

src/checkstyle/checks/modifier/RedundantModifierCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.modifier;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;

src/checkstyle/checks/naming/ListenerNameCheck.hx

@@ -2,8 +2,6 @@ package checkstyle.checks.naming;
 
 import checkstyle.utils.ExprUtils;
 import haxe.macro.Expr;
-import haxe.macro.Expr.Field;
-import haxe.macro.Expr.Function;
 
 @name("ListenerName")
 @desc("Checks the naming conventions of event listener functions specified using `listeners` property.")

src/checkstyle/checks/naming/LocalVariableNameCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.naming;
 
 import checkstyle.utils.ExprUtils;
-import haxeparser.Data;
 
 @name("LocalVariableName")
 @desc("Checks that the local variable names conform to a format specified by the `format` property.")

src/checkstyle/checks/size/FileLengthCheck.hx

@@ -1,7 +1,5 @@
 package checkstyle.checks.size;
 
-import haxeparser.Data.Token;
-
 @name("FileLength")
 @desc("Checks for long source files. If a source file becomes very long it is hard to understand. Therefore long classes should usually be refactored into several individual classes that focus on a specific task.")
 class FileLengthCheck extends Check {

src/checkstyle/checks/size/MethodCountCheck.hx

@@ -1,9 +1,6 @@
 package checkstyle.checks.size;
 
 import checkstyle.token.TokenTree;
-import haxeparser.Data;
-
-using checkstyle.utils.ArrayUtils;
 
 @name("MethodCount")
 @desc("Checks the number of methods declared in each type. This includes the number of each scope (`private` and `public`) as well as an overall total.")

src/checkstyle/checks/size/MethodLengthCheck.hx

@@ -3,7 +3,6 @@ package checkstyle.checks.size;
 import checkstyle.utils.ExprUtils;
 import haxe.macro.Expr;
 import haxe.macro.Expr.Field;
-import haxe.macro.Expr.Function;
 
 @name("MethodLength")
 @desc("Checks for long methods. If a method becomes very long it is hard to understand. Therefore long methods should usually be refactored into several individual methods that focus on a specific task.")

src/checkstyle/checks/size/ParameterNumberCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.size;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;

src/checkstyle/checks/type/AnonymousCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.type;
 
 import checkstyle.utils.ExprUtils;
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.FieldUtils;

src/checkstyle/checks/type/DynamicCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.type;
 
 import haxe.macro.Expr;
-import haxeparser.Data;
 import checkstyle.utils.ComplexTypeUtils;
 
 @name("Dynamic")

src/checkstyle/checks/type/ReturnCheck.hx

@@ -2,7 +2,6 @@ package checkstyle.checks.type;
 
 import checkstyle.utils.ExprUtils;
 import haxe.macro.Expr;
-import haxeparser.Data;
 
 using checkstyle.utils.FieldUtils;
 

src/checkstyle/checks/type/TypeCheck.hx

@@ -1,6 +1,5 @@
 package checkstyle.checks.type;
 
-import haxeparser.Data;
 import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;

src/checkstyle/checks/whitespace/ArrayAccessCheck.hx

@@ -35,7 +35,6 @@ class ArrayAccessCheck extends Check {
 					}
 
 					if (!spaceInside) {
-						var eString = checker.getString(e.pos.min, e.pos.max);
 						if (checker.file.content.substr(e2.pos.min - 1, 1) == " ") logPos("Space between [ and index", e.pos);
 						if (checker.file.content.substr(e2.pos.max, 1) == " ") logPos("Space between index and ]", e.pos);
 					}

src/checkstyle/checks/whitespace/OperatorWhitespaceCheck.hx

@@ -5,9 +5,6 @@ import checkstyle.utils.TokenTreeCheckUtils;
 import checkstyle.checks.whitespace.WhitespaceCheckBase.WhitespacePolicy;
 import checkstyle.checks.whitespace.WhitespaceCheckBase.WhitespaceUnaryPolicy;
 import haxeparser.Data;
-import haxe.macro.Expr;
-
-using checkstyle.utils.ArrayUtils;
 
 @name("OperatorWhitespace")
 @desc("Checks that whitespace is present or absent around a operators.")

src/checkstyle/checks/whitespace/OperatorWrapCheck.hx

@@ -1,7 +1,6 @@
 package checkstyle.checks.whitespace;
 
 import haxeparser.Data;
-import haxe.macro.Expr;
 
 @name("OperatorWrap")
 @desc("Checks line wrapping with operators.")

src/checkstyle/checks/whitespace/SeparatorWhitespaceCheck.hx

@@ -4,9 +4,6 @@ import checkstyle.Checker.LinePos;
 import checkstyle.token.TokenTree;
 import checkstyle.checks.whitespace.WhitespaceCheckBase.WhitespacePolicy;
 import haxeparser.Data;
-import haxe.macro.Expr;
-
-using checkstyle.utils.ArrayUtils;
 
 @name("SeparatorWhitespace")
 @desc("Checks that whitespace is present or absent around a separators.")

src/checkstyle/checks/whitespace/TabForAligningCheck.hx

@@ -2,8 +2,6 @@ package checkstyle.checks.whitespace;
 
 import checkstyle.CheckMessage.SeverityLevel;
 
-using checkstyle.utils.StringUtils;
-
 @name("TabForAligning")
 @desc("Checks if there are any tabs in the middle of a line.")
 class TabForAligningCheck extends LineCheckBase {

src/checkstyle/checks/whitespace/WhitespaceAfterCheck.hx

@@ -3,7 +3,6 @@ package checkstyle.checks.whitespace;
 import checkstyle.token.TokenTree;
 import checkstyle.utils.TokenTreeCheckUtils;
 import haxeparser.Data;
-import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;
 

src/checkstyle/checks/whitespace/WhitespaceAroundCheck.hx

@@ -4,7 +4,6 @@ import checkstyle.Checker.LinePos;
 import checkstyle.token.TokenTree;
 import checkstyle.utils.TokenTreeCheckUtils;
 import haxeparser.Data;
-import haxe.macro.Expr;
 
 using checkstyle.utils.ArrayUtils;
 

src/checkstyle/checks/whitespace/WhitespaceCheckBase.hx

@@ -4,9 +4,6 @@ import checkstyle.Checker.LinePos;
 import checkstyle.token.TokenTree;
 import checkstyle.utils.TokenTreeCheckUtils;
 import haxeparser.Data;
-import haxe.macro.Expr;
-
-using checkstyle.utils.ArrayUtils;
 
 @ignore("base class for OperatorWhitespace and SeparatorWhitespace")
 class WhitespaceCheckBase extends Check {

src/checkstyle/token/TokenStream.hx

@@ -1,7 +1,6 @@
 package checkstyle.token;
 
 import byte.ByteData;
-import haxe.macro.Expr;
 import haxeparser.Data.Token;
 import haxeparser.Data.TokenDef;
 import hxparse.Position;

src/checkstyle/token/TokenTreeBuilder.hx

@@ -1,9 +1,7 @@
 package checkstyle.token;
 
 import byte.ByteData;
-import haxe.macro.Expr;
 import haxeparser.Data.Token;
-import haxeparser.Data.TokenDef;
 
 import checkstyle.token.walk.WalkFile;
 

src/checkstyle/token/walk/WalkAbstract.hx

@@ -1,9 +1,5 @@
 package checkstyle.token.walk;
 
-import haxe.macro.Expr;
-import haxeparser.Data.Token;
-import haxeparser.Data.TokenDef;
-
 import checkstyle.token.TokenStream;
 import checkstyle.token.TokenStreamProgress;
 import checkstyle.token.TokenTree;

src/checkstyle/token/walk/WalkArrayAccess.hx

@@ -1,9 +1,5 @@
 package checkstyle.token.walk;
 
-import haxe.macro.Expr;
-import haxeparser.Data.Token;
-import haxeparser.Data.TokenDef;
-
 import checkstyle.token.TokenStream;
 import checkstyle.token.TokenStreamProgress;
 import checkstyle.token.TokenTree;