Retry interrupted std stream read/write calls. #651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hashlink profiler causes some Linux system calls to be interrupted. Previously, error handling was added for
std/file.c
read/write operations. However, the read/write calls made by sys.io.Process use instead the unistd read/write functions which are also affected by the interrupts.This pull request extends the previously introduced error handling also to the unistd read/write calls in
std/process.c
.The behaviour can be tested with the following program, which uses the stdout, stderr and stdin streams via sys.io.Process:
Previously, when running with the profiler
hl --profile 1000 test.hl
the test program fails with the exception:With the proposed changes the test program runs normally and can be profiled.