Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hlc] Implement automatic compilation with make and Build.xml templates #706

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Sep 1, 2024

This adds two new templates to the hashlink support library to simplify hlc compilation: make for a regular Makefile, and hxcpp for a Build.xml. Both of these implement automated compilation, so if you add either of these then an executable is generated automatically:

-D hlgen.makefile=make
-D hlgen.makefile=hxcpp

The Makefile is smart so it will only recompile files whose dependencies have changed. I've tested it on Linux and on Windows with mingw.

Like with the Visual Studio templates, on Windows the templates expect a HASHLINK environment variable to point to the hashlink installation. With the Build.xml template, the installation can also point to the hashlink sources, provided that they contain binaries generated by hl.sln.

Use LDLIBS for passing libraries to the linker:
https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html#index-LDLIBS

Compile .c files into separate .o files to avoid recompiling the entire
project every time. Use .d files to keep track of .c files that
depend on .h files. For reference:
https://stackoverflow.com/a/52036564
For some reason, mingw doesn't like `-I./`, this causes it to be unable
to find the includes
Previously it would always generate them next to the .c files,
regardless of whether hlgen.makefilepath had been set. Now it ensures
that it doesn't write outside of the Makefile directory.

This means that it first has to create the directories, otherwise the
compiler complains about directories not existing when it tries to
write the output files.

".SUFFIXES" also has to be set as an empty target, otherwise the built-
in rules mess up the rule dependencies.
@skial skial mentioned this pull request Sep 4, 2024
1 task
@kLabz
Copy link
Contributor

kLabz commented Nov 1, 2024

Small documentation / default value handling issue:

Set hlgen.makefile for automatic native compilation

But adding -D hlgen.makefile (without setting a value) gives:

Automatic native compilation not yet implemented for 1

If picking a default value is not something we want, it would be nice to list correct values in this error message I think?

@tobil4sk
Copy link
Member Author

tobil4sk commented Nov 1, 2024

If picking a default value is not something we want, it would be nice to list correct values in this error message I think?

The default value was working before, I just forgot about it with my changes so this should be fixed. Maybe it should be updated though:

  • vs2019 for windows
  • make for other systems

Aside from this, the makefile here doesn't support mac at the moment (mac linker doesn't support -l:fmt.hdll syntax). This will have to be fixed before this can be merged. -lfmt.hdll doesn't work because hdll libraries don't follow the standard naming of lib[name].so. We can instead link with the full path /usr/local/lib/fmt.hdll, however, on linux this hardcodes the full path for loading the library, unless fmt.hdll is built with -soname (already the case with the hashlink cmake file, but not the hashlink make file). So there are two options:

  • Use the full path universally, requiring hdlls (including user-made ones) to be built with -soname on linux.
  • Generate separate linking flags for mac and linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants