Fix enclosing positions #11892
Merged
Fix enclosing positions #11892
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
force-pushed
the
fix/enclosing_positions
branch
from
bbcfa43 to
5b9609b
Compare
kLabz
force-pushed
the
fix/enclosing_positions
branch
from
5b9609b to
f378b00
Compare
kLabz
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reusing type / field positions in places where this could wrongly trigger some display mechanisms.
Also exposes
haxe.macro.PositionTools.toZeroRange(pos)so that macros can point generated stuff at a type or field for example, without reusing the whole position (which can also impact our display services).Extracted #11925 for now