-
Notifications
You must be signed in to change notification settings - Fork 99
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding constructor check to @:structInit canAssign check
- Loading branch information
Showing
3 changed files
with
148 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 48 additions & 8 deletions
56
src/test/resources/testData/annotation.semantic/AssignStructInit.hx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,62 @@ | ||
| package; | ||
| @:structInit class MyStruct { | ||
| //NOTE: should not show warning about final when in structInit class | ||
| final name:String; | ||
| var age:Int; | ||
| var height:Float = 3.0; // init = same as optional | ||
| @:optional var address:String; | ||
|
|
||
| } | ||
|
|
||
| class Test { | ||
| public function new() { | ||
| // correct | ||
| // CORRECT | ||
| var s1:MyStruct = {name:"name", age:30}; | ||
| var s2:MyStruct = {name:"name", age:30, height:1.0, address:"address 1"}; | ||
|
|
||
| // WRONG | ||
| var <error descr="Incompatible type: missing member(s) age:Int">s3:MyStruct = {name:"name"}</error>; // missing field | ||
| var <error descr="Incompatible type: {...} should be MyStruct">s4:MyStruct = {name:"name", age:30, address:"address 1", extra:"field"}</error>; // to many fields | ||
|
|
||
| // CORRECT (TypeParameter) | ||
| var typeParamA:MyTypeParamStruct<String> = {valueA:"name", valueB:30}; | ||
| // WRONG (TypeParameter) | ||
| var <error descr="Incompatible type: Incompatible member type(s) (have 'valueA:String' wants 'valueA:Int')">typeParamB:MyTypeParamStruct<Int> = {valueA:"name", valueB:30}</error>; | ||
|
|
||
| //CORRECT (constructor) | ||
| var NormalConstructor:ConstrcutorStruct<String> = {name:"str", value:1.0, type: ValueA}; | ||
| var diffrentOrder:ConstrcutorStruct<String> = {value:1.0, type: ValueA, name:"str"}; | ||
| var usingDefaults:ConstrcutorStruct<String> = {value:1.0, name:"str"}; | ||
|
|
||
| // WRONG (constructor) | ||
| var <error descr="Incompatible type: Incompatible member type(s) (have 'value:String' wants 'value:Float')">wrongType:ConstrcutorStruct<String> = {value:"1.0", name:"str"}</error>; | ||
| var <error descr="Incompatible type: Incompatible member type(s) (have 'name:Int' wants 'name:String')">wrongTypeTypeParameter:ConstrcutorStruct<String> = {value:1.0, name:1}</error>; | ||
| var <error descr="Incompatible type: missing member(s) value">missingField:ConstrcutorStruct<String> = { name:"str"}</error>; | ||
|
|
||
| } | ||
| } | ||
|
|
||
| @:structInit class MyStruct { | ||
| //NOTE: should not show warning about final when in structInit class | ||
| final name:String; | ||
| var age:Int; | ||
| var height:Float = 3.0; // init = same as optional | ||
| @:optional var address:String; | ||
|
|
||
| } | ||
|
|
||
| @:structInit class MyTypeParamStruct<T> { | ||
| var valueA:T; | ||
| var valueB:Int; | ||
|
|
||
| } | ||
|
|
||
| enum TestNum { ValueA; ValueB; } | ||
|
|
||
| @:structInit | ||
| class ConstrcutorStruct<T> { | ||
| public var name(default,null) : T; | ||
| public var value(default,null) : Float; | ||
| public var type(default,null) : TestNum; | ||
| public var intenral(default,null) : String; | ||
|
|
||
| public inline function new( name : T, value : Float, type = ValueB ) { | ||
| this.name = name; | ||
| this.type = type; | ||
| this.value = value; | ||
| this.intenral = "internalValue"; | ||
| } | ||
| } |