Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for #19 #21

Closed
wants to merge 1 commit into from
Closed

Potential fix for #19 #21

wants to merge 1 commit into from

Conversation

RaddishIoW
Copy link

No description provided.

@RaddishIoW RaddishIoW self-assigned this Apr 26, 2021
@HarelM
Copy link
Collaborator

HarelM commented Apr 27, 2021

I've study this to some extent.
Please note that this permission will require you to explain why you need to use geolocation in the background without telling the user so.
I tried to explain in the store why I need this permission and didn't get a respond or an approval.
When you use geolocation in the background but you have a notification icon to show that your app is running you don't need this permission and it is not considered background.
I'll link to the original issue in the repo where I found a video about it.

@HarelM
Copy link
Collaborator

HarelM commented Apr 27, 2021

See my comment here:
mauron85#688 (comment)

@HarelM
Copy link
Collaborator

HarelM commented May 3, 2021

I think this PR can be canceled...?

@RaddishIoW
Copy link
Author

Yeah you're probably right - I think it would be needed for the "Headless Mode" on android... but I think we should probably do away with that in 2.0?
Might be worth noting in the docs why we don't need this permission and why it's not included?

@HarelM
Copy link
Collaborator

HarelM commented May 3, 2021

Sure. I'm not sure how interesting headless mode is for app developers... Getting the permission in the play store is hard and seems like a barrier. at least for me it was...
In any case, adding some information in the documentation is a good idea.

@RaddishIoW RaddishIoW closed this Jun 2, 2021
@RaddishIoW RaddishIoW deleted the RaddishIoW/issue19 branch June 26, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants