Remove dead code that prevents easy installation in Dockerfile without access to CUDA runtime #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t access to CUDA runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dan & Hermann,
I noticed that including flash-fft-conv in a docker image is very difficult. As it requires access to a CUDA runtime instance during compilation. As noticed by Jacob Huffman the main issue is some dead code that seems not to be used anywhere.
This PR removes that code, allowing to include flash-fft-conv without need to CUDA runtime instances. This makes it very simple to include flash-fft-conv in Docker images.
Best,
David