Support OGG on JS, fall back to stb #1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGG is illegal on !HL without stb lib
This reverts commit 1fd1453.
|
Narrowed the scope to just native browser handling when possible, so ignoring OGGs is the same behavior as before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Officially support Ogg audio files on JS.
stb_ogg_soundis required still (OGGs are ignored otherwise), but it attempts native browser handling of the file before falling back tostb_ogg_sound.This preserves the ability to use
stb_ogg_soundoutside of HL or JS, but I did not test that.