Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed premature input deletion #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed premature input deletion #223

wants to merge 2 commits into from

Conversation

onehundredfeet
Copy link
Contributor

The JQuery results in openFile were being destroyed by this deleting the element before it could be used even though 200ms is a long time. It appears to just be needed for cleanup.

@onehundredfeet
Fixed premature input deletion
9580871 
The JQuery results in openFile were being destroyed by this deleting the element before it could be used even though 200ms is a long time.  It appears to just be needed for cleanup.
@onehundredfeet
Merge remote-tracking branch 'upstream/master' into premature-input-d…
aa9022e 
…elete-fix
@Speedphoenix
Copy link
Collaborator

Speedphoenix commented Sep 28, 2022 •
edited
Loading

Since removing the .toString() on the getFile 2 lines below (ad1f63f) the focus event went from a few seconds on a large cdb to almost instant. Could you check if the increased time is still needed? As you mentioned 200ms is already a long time.

@onehundredfeet
Copy link
Contributor Author

Sure. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onehundredfeet @Speedphoenix