Add metrics reporting #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeavyHorst
reviewed
Oct 2, 2020
|
Updated PR with fixes to your comments and other small fixups. Hope you would not mind adding me to authors list as mentioned in contributing guide. |
Fix import ordering Add copyright header Add comments to fix golint warnings Add [email protected] to AUTHORS Add prometheus endpoints to docs and fix error message
syndicut
force-pushed
the
metrics-support
branch
from
cfa02d0
to
d31bb0d
Compare
|
Thanks, great addition. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added metrics reporting to support monitoring remco's state. This PR is inspired by this hashicorp/consul-template#1378 consul-template PR and metrics support in consul itself. Metrics are reported by go-metrics library (which is also used in consul and planned to be used in consul-template: hashicorp/consul-template#1395).
Exposed metrics: