Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sonic2010 set object format #56

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add sonic2010 set object format #56

merged 1 commit into from
Oct 26, 2023

Conversation

jamescarter2001
Copy link
Contributor

Will add XML examples at a later time.

@jamescarter2001 jamescarter2001 force-pushed the main branch 4 times, most recently from 920bab8 to dde00ea Compare October 26, 2023 13:36
PTKay
PTKay requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@PTKay PTKay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Noticed some parts of this that would benefit from a couple of changes, please take a look:

hedgedocs/docs/hedgehog-engine/sonic2010/files/setobject.md Outdated Show resolved Hide resolved
hedgedocs/docs/hedgehog-engine/sonic2010/files/setobject.md Outdated Show resolved Hide resolved
@PTKay
Copy link
Member

PTKay commented Oct 26, 2023

LGTM! This would look better with the XML examples, but I'll trust that you'll contribute with them at a later date

@PTKay PTKay merged commit 72a2b06 into HedgeDocs:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PTKay PTKay PTKay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescarter2001 @PTKay