Added Identity Function for Math lib #37
Conversation
|
Everything after these changes will look perfect. I think your way is faster than the mathjs way, as you dont have to copy twice and dont have to convert to Mat and back nor make a call to mathjs library. Will merge after these small issues are fixed - thank you! |
identity.hhs
Outdated
| return new Mat([[1]]); | ||
| } | ||
|
|
||
| // Now we can start on creating the Id matrix | ||
| let result = []; | ||
| let result = new Mat().zeros(n, n); |
There was a problem hiding this comment.
| let result = new Mat().zeros(n, n); | |
| let result = new Mat().zeros(input, input); |
There was a problem hiding this comment.
n not defined, i assume you meant input for this and the one below (for loops n -> input)
identity.hhs
Outdated
| return new Mat([[1]]); | ||
| } | ||
|
|
||
| // Now we can start on creating the Id matrix | ||
| let result = []; | ||
| let result = new Mat().zeros(n, n); | ||
| for (let i = 0; i < n; i++){ |
There was a problem hiding this comment.
| for (let i = 0; i < n; i++){ | |
| for (let i = 0; i < input; i++){ |
identity.hhs
Outdated
| row[i] = 1; | ||
| result += row; | ||
| } | ||
| result[i][i] = 1; |
There was a problem hiding this comment.
| result[i][i] = 1; | |
| result.val[i][i] = 1; |
because we're modifying a Mat instead of a JS array we can't access the indices directly, but rather have to access them through .val otherwise we get a 'cannot read 0' error
| @@ -16,23 +15,27 @@ function identity(input) { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
| if ( !(arguments.length === 1) ) { | |
| throw new Error('Exception occurred in identity. Only 1 argument allowed, but a different number were entered.'); | |
| } |
just a good safety check on the arguments so if the user uses the function incorrectly, they know which function they used incorrectly and why
|
Good job, I apologize for the late merge, I thought I merged it earlier. |
Identity Function: