Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add padding to Sessions info banner #2694

Closed
wants to merge 1 commit into from

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Sep 26, 2024

We have corrected the typos in the Sessions info banner on the Free plan. Specifically, changed "Sessions are a Pro feature" to "Sessions is a Pro feature" and "September 27st" to "September 27th". Additionally, we have added padding to the bottom of this info banner to prevent it from touching the demo section below.


Browser testing result ✅

Success image

Step: [Verify] The Sessions info banner text reads 'Sessions is a Pro feature. In order to keep using them, you need to upgrade your plan before September 27th, 2024. Upgrade to Pro' with bottom padding.

The assertion is that the Sessions info banner text reads 'Sessions is a Pro feature. In order to keep using them, you need to upgrade your plan before September 27th, 2024. Upgrade to Pro' with bottom padding. The HTML shows a div with id 30 and name 'Sessions is a Pro feature' containing a paragraph with id 32 that has the exact text mentioned in the assertion. The screenshot confirms the presence of this text in the banner. However, the assertion also mentions 'with bottom padding', which cannot be verified through the provided HTML or screenshot as it pertains to CSS styling, which is not visible in the given data.

Success Image 0-0


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review and I'll address it.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs to see more details.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:38pm
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:38pm
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:38pm

@use-tusk use-tusk bot closed this Sep 26, 2024
@use-tusk use-tusk bot changed the title Tusk WIP - Free plan Sessions info banner typos and padding Fix typos and add padding to Sessions info banner Sep 27, 2024
@use-tusk use-tusk bot marked this pull request as ready for review September 27, 2024 00:02
@use-tusk use-tusk bot deleted the tusk-fix-sessions-banner-092620242333 branch September 27, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants