Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service name validation #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fhoekstra
Copy link

Implements #59.
I just couldn't wait.

I do have doubts about one "missing" test case. What if the service name is invalid (that would cause a ValueError) and it has not been called (that would raise AssertionError).

I think I am fine with any of them being called, or both.

@fhoekstra
Copy link
Author

Added that "missing" case in b070528, by calling pytest.raises with a tuple of assertions.

@HelloThisIsFlo
Copy link
Owner

Hey 👋

For now, you can consider this project unmaintained, unfortunately.

I haven't had time to maintain this repo in the last few years, in good parts because I moved home and I haven't had a HomeAssistant setup for a very long time. So I'm a bit disconnected with the latest updates, and it's a huge overhead to start everything again, get context and understand how to fix issues on this project

However, I've finally taken the task to set up my server at home again, so I'll probably use this project for my own use again soon.

This means I may bring this project up-to-date in the next few months. No guarantees, obviously, but I may.

Best,
Flo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants