Initialized pointers to nullptr to avoid segmentation fault when stop… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyu-hesaitech
force-pushed
the
master
branch
from
20eae37
to
7d00ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentation fault on HesaiLidarSdk::Stop()
When calling the Stop method of an HesaiLidarSdk object created with the DATA_FROM_PCAP option a segmentation fault ocour. This happens because pointers are not initialized to nullptr an thus, when the destructor of Lidar<T_Point> is called, a delete is performed on ptc_client_ even if it has not been allocated. To solve the issues all pointers in Lidar<T_Point> has been intialized to nullptr (I would suggest to check also all the pointers in the other classes).