Add custom property support to AppConfig. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baret
reviewed
Apr 28, 2021
zircon.core/src/commonMain/kotlin/org/hexworks/zircon/api/application/AppConfigKey.kt
Show resolved
Hide resolved
zircon.core/src/commonMain/kotlin/org/hexworks/zircon/api/application/AppConfig.kt
Outdated
Show resolved
Hide resolved
adam-arold
reviewed
Apr 29, 2021
There was a problem hiding this comment.
This is a great idea, @nanodeath! Also LGTM apart from a small issue with getProperty.
zircon.core/src/commonMain/kotlin/org/hexworks/zircon/api/application/AppConfig.kt
Outdated
Show resolved
Hide resolved
...n.core/src/commonMain/kotlin/org/hexworks/zircon/api/builder/application/AppConfigBuilder.kt
Show resolved
Hide resolved
This enables plugin authors to easily set and retrieve configuration options for the end developer. Closes Hexworks#380.
nanodeath
force-pushed
the
custom-properties
branch
from
1943730 to
d14ea5b
Compare
|
I've incorporated everyone's suggestions, I think! So the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables plugin authors to easily set and retrieve configuration options
for the end developer.
Closes #380.