Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure ci #204

Merged
merged 4 commits into from
Feb 26, 2024
Merged

configure ci #204

merged 4 commits into from
Feb 26, 2024

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented Feb 23, 2024

I was setting up CI for hvm-core; figured it might be useful here too.

Configures GitHub Actions to automatically check/test/lint/fmt/spellcheck PRs.

@tjjfvi tjjfvi requested a review from developedby February 23, 2024 18:26
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never configured a github CI myself, so I'll trust you that the details are correct.

cspell.json Outdated Show resolved Hide resolved
cspell.json Outdated Show resolved Hide resolved
@developedby
Copy link
Member

What is the spell-checking tool you're using here?

@tjjfvi
Copy link
Contributor Author

tjjfvi commented Feb 23, 2024

Sorry, I reviewed the list of words for errors, but I guess I missed those two.

cSpell. I've used it a bit in the past, and have found it very helpful.

@tjjfvi tjjfvi marked this pull request as ready for review February 23, 2024 20:41
@tjjfvi tjjfvi requested a review from developedby February 23, 2024 20:42
@tjjfvi tjjfvi merged commit 244acd1 into master Feb 26, 2024
5 checks passed
@tjjfvi tjjfvi deleted the ci branch February 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants