[sc-475] Add documentation for new match options #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #475: Add documentation for new match options. |
imaqtkatt
requested review from
developedby and
LunaAmora
and removed request for
developedby
developedby
requested changes
Feb 27, 2024
developedby
approved these changes
Feb 27, 2024
LunaAmora
suggested changes
Feb 28, 2024
| // If the number is 1, then return 1 | ||
| 1: 1 | ||
| // Otherwise, and return the sum of (fib (n-2 + 1)) and (fib n-2) | ||
| 2+: (+ (fibonacci (+ n-2 1)) (fibonacci n-2)) |
There was a problem hiding this comment.
Are the names like n-2 still binded automatically? If so, should probably still say it here. (unless another doc is saying that and i didn't find)
There was a problem hiding this comment.
If the successor pattern is 3+ then the bind will be var-3 and so on
There was a problem hiding this comment.
Yes, i know, but a doc should be saying that. The name n-2 is just appearing magically without explanation
developedby
requested changes
Feb 28, 2024
developedby
approved these changes
Feb 28, 2024
LunaAmora
approved these changes
Feb 28, 2024
imaqtkatt
deleted the
chore/sc-475/add-documentation-for-new-match-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.