[sc-540] Use hvm-core eta-reduction pass #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #540: Use hvm-core eta-reduction pass. |
developedby
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Why did you remove these two files? Isn't the test still valid?
There was a problem hiding this comment.
For a moment I thought these files were just testing the lambda-level desugaring because the new results maintained some references, the eta pass should be called after the pre-reduce I think
There was a problem hiding this comment.
We could do eta -> inline -> pre-reduce -> eta. Eta reduction and inlining before will make pre-reduction a bit faster.
imaqtkatt
force-pushed
the
feature/sc-540/use-hvm-core-eta-reduction-pass
branch
from
6cf9594 to
3126eba
Compare
developedby
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.