Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc-543] Add hvml test on example programs #261

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[sc-543] Add hvml test on example programs #261

merged 3 commits into from
Apr 10, 2024

Conversation

imaqtkatt
Copy link
Contributor

No description provided.

@imaqtkatt imaqtkatt self-assigned this Apr 9, 2024
@imaqtkatt imaqtkatt requested a review from developedby April 9, 2024 18:48
developedby
developedby reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead we could have these files in the examples directory and the test function reads from there?
This way we test the examples and are forced to keep them up-to-date, give users more examples and don't duplicate these programs.

@developedby
Copy link
Member

That's what hvm-core is doing I think, if you want to have a look there.

@imaqtkatt imaqtkatt requested a review from developedby April 10, 2024 11:00
@imaqtkatt imaqtkatt added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 56b3a0b Apr 10, 2024
5 checks passed
@imaqtkatt imaqtkatt deleted the feature/sc-543/add-hvml-test-on-example-programs branch April 10, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedby developedby developedby approved these changes

Assignees

@imaqtkatt imaqtkatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imaqtkatt @developedby