-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSVC and GitHub Actions #311
base: main
Are you sure you want to change the base?
Conversation
Rust and CU version works fine, C doesn't, might be because of the pasting the error for better reference:
|
Yes you will need at least msvc 17.5. |
could you also remove the windows disclaimer from the README.md and add that for windows, you need MSVC ver >= 17.5 please? |
On both windows and linux seems like it's ok, can't test on a mac right now, will try it later. |
Tested on MacOS, all examples in We're still discussing a few things internally before merging, specially the changes to |
Thanks for the PR! I really appreciate it. It changes some things I'm not aware will be safe though. I'll go through it later, when we have more tests |
Get run-c and run-cu works with MSVC.
/experimental:c11atomics
and-std=c11
is required for stdatomicAdd GitHub Actions CI for building and linting.
(This is a clean PR from #294)