CUDA Basic IO #347
Merged
CUDA Basic IO #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorTaelin
approved these changes
May 27, 2024
src/hvm.cu
Outdated
| // Book of Definitions | ||
| struct Book { | ||
| u32 defs_len; | ||
| Def defs_buf[0x4000]; // 256 MB | ||
| u32 ffns_len; | ||
| FFn ffns_buf[0x4000]; // 256 MB |
There was a problem hiding this comment.
these sizes look right. defs are larger than fns. why same size?
src/hvm.cu
Outdated
| return ctr; | ||
| } | ||
|
|
||
| // Reads back a UTF-16 string. |
There was a problem hiding this comment.
strings in hvm are actually just lists of unicode codepoints, we must update that
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
PUT_TEXT,GET_TIME, andPUT_TIMEIO operations.