Numeric Casting Operations #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove out of range casts as in C these are UB
enricozb
requested review from
VictorTaelin and
tjjfvi
and removed request for
VictorTaelin
enricozb
force-pushed
the
enricozb/cast-num
branch
from
fdc174e to
3853c69
Compare
tjjfvi
reviewed
May 30, 2024
| @@ -4,6 +4,6 @@ expression: rust_output | |||
| input_file: tests/programs/empty.hvm | |||
| --- | |||
| exit status: 101 | |||
| thread 'main' panicked at src/ast.rs:508:41: | |||
| thread 'main' panicked at src/ast.rs:527:41: | |||
There was a problem hiding this comment.
off-topic but this diff is pretty annoying; we should figure out a better way to test this
Closed
tjjfvi
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for numeric casting operations,
[u24],[i24],[f24].Fixes #322.
Casts are always defined, and spiritually follow rusts numeric casting semantics:
i24 <-> u24is just reinterpretation of bits.f24 -> i24orf24 -> u24casts to the "closest" integer representing this float, saturating if out of range and0ifNaN.i24 -> f24oru24 -> f24casts to the "closest" float representing this integer.