-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recursive pretty print #368
Conversation
This comment has been minimized.
This comment has been minimized.
You just removed the stack? That's a regression, in CUDA this will cause the compiler to be unable to estimate the stack size of the pretty print function, which can have harsh consequences on performance elsewhere and cause segfaults in unrelated code, making us unable to use the pretty printer for debugging purposes. Have you tested using it inside the interaction kernel on the GPU? |
I didn't test pretty print within any of the cuda code, didn't think of that as a use case. We can have a stacked version for debugging and use this for the output on the host then? |
Perf run for
|
this should be handled correctly after the C/CUDA readback on Rust is implemented, as that'll allow just using Rust's stringifier instead
Fixes issues with segfault after printing: #360.
Also it doesn't overload the
ERA
node.Of course a large enough net will still overflow the stack. On my machine, this example bend code:
Which previously segfaulted at
create(37)
, now segfaults somewhere betweencreate(50000)
andcreate(100000)
.