tan + sin funcs #391
Merged
tan + sin funcs #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
developedby
requested changes
Jun 19, 2024
src/hvm.c
Outdated
| @@ -570,6 +570,10 @@ static inline Numb operate(Numb a, Numb b) { | |||
| case OP_AND: return new_f24(atan2f(av, bv)); | |||
| case OP_OR: return new_f24(logf(bv) / logf(av)); | |||
| case OP_XOR: return new_f24(powf(av, bv)); | |||
| case OP_SHL: return new_f24(sin(av + bv)); | |||
| case FP_SHL: return new_f24(sin(av + bv)); | |||
There was a problem hiding this comment.
We don't need to waste f24 FP_SHL and FP_SHR here
src/hvm.cu
Outdated
| @@ -676,6 +676,10 @@ __device__ __host__ inline Numb operate(Numb a, Numb b) { | |||
| case OP_AND: return new_f24(atan2f(av, bv)); | |||
| case OP_OR: return new_f24(logf(bv) / logf(av)); | |||
| case OP_XOR: return new_f24(powf(av, bv)); | |||
| case OP_SHL: return new_f24(sin(av + bv)); | |||
| case FP_SHL: return new_f24(sin(av + bv)); | |||
src/hvm.rs
Outdated
| @@ -407,6 +407,10 @@ impl Numb { | |||
| OP_AND => Numb::new_f24(av.atan2(bv)), | |||
| OP_OR => Numb::new_f24(bv.log(av)), | |||
| OP_XOR => Numb::new_f24(av.powf(bv)), | |||
| OP_SHL => Numb::new_f24((av + bv).sin()), | |||
| OP_SHR => Numb::new_f24((av + bv).tan()), | |||
| FP_SHL => Numb::new_f24((av + bv).sin()), | |||
developedby
requested changes
Jun 19, 2024
src/ast.rs
Outdated
| @@ -79,6 +79,8 @@ impl<'i> CoreParser<'i> { | |||
| _ if self.try_consume("&") => hvm::OP_AND, | |||
| _ if self.try_consume("|") => hvm::OP_OR, | |||
| _ if self.try_consume("^") => hvm::OP_XOR, | |||
| _ if self.try_consume("sin") => hvm::OP_SHL, | |||
There was a problem hiding this comment.
These symbols are trying to uniquely map to operators, so we shouldn't add sin and tan here. Notice how there's no pow, log and atan2.
There was a problem hiding this comment.
fair enough but in the context of [ nothing else could appear there, thought it would be a bit more readable.
developedby
approved these changes
Jun 20, 2024
|
Perf run for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #384