Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use Encoder::op_num #120

Merged
merged 1 commit into from
Apr 6, 2024
Merged

re-use Encoder::op_num #120

merged 1 commit into from
Apr 6, 2024

Conversation

enricozb
Copy link
Contributor

@enricozb enricozb commented Apr 6, 2024

The Instruction::OpNum optimization was accidentally removed in #84.

This PR re-introduces the optimization.

@enricozb enricozb requested a review from tjjfvi April 6, 2024 16:02
@HigherOrderBot
Copy link
Collaborator

Perf run for 9caffc6:

file              mode        main          9caffc6dc1d7
========================================================
merge_sort        intr-singl       7.258 s       7.186 s
                  intr-multi       3.564 s       3.742 s
--------------------------------------------------------
boom              intr-singl       2.227 s       2.282 s
                  intr-multi       2.348 s       1.602 s
--------------------------------------------------------
bitonic_sort_lam  intr-singl      11.089 s      11.553 s
                  intr-multi       5.520 s       5.607 s
--------------------------------------------------------
radix_sort_lam    intr-singl       9.311 s       9.604 s
                  intr-multi       4.628 s       4.630 s
--------------------------------------------------------
sum_tree          intr-singl       9.132 s       9.089 s
                  intr-multi       4.364 s       4.433 s
--------------------------------------------------------
c2                intr-singl       0.000 s       0.000 s
                  intr-multi       0.001 s       0.001 s
--------------------------------------------------------
sum_tail          intr-singl       1.119 s       1.133 s
                  intr-multi       1.130 s       1.119 s
--------------------------------------------------------
sum_rec           intr-singl      14.332 s      13.451 s
                  intr-multi       7.056 s       6.960 s

@enricozb enricozb added this pull request to the merge queue Apr 6, 2024
Merged via the queue into main with commit f13f24c Apr 6, 2024
5 checks passed
@enricozb enricozb deleted the enricozb/op_num branch April 6, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants