Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing #70

Open
1 of 4 tasks
hannesbecher opened this issue Dec 1, 2023 · 3 comments
Open
1 of 4 tasks

improve testing #70

hannesbecher opened this issue Dec 1, 2023 · 3 comments
Assignees

Comments

@hannesbecher
Copy link
Contributor

hannesbecher commented Dec 1, 2023

Thorough testing will simplify development in the long run. It will help us to pick up mistakes sooner and make sure the pipeline runs on various datasets not only our personal favourites.

I think it would be good to (1) add a test for the pipeline to start with multiple VCF files (one per chromosome) and (2) to add the code to run this to README.md.

Specifics:

  • find data (per-chromosome files for the bee data should be in the shared data folder in HighlanderLab on Eddie)
  • add another small test data folder to repo
  • also test cluster execution
  • update README.md accordingly

I know I am supposed to work on the chromosome names... coming soon.

@hannesbecher hannesbecher self-assigned this Dec 1, 2023
@janaobsteter
Copy link
Collaborator

janaobsteter commented Dec 1, 2023

@hannesbecher , there is already additional files there. The previous test (when we didn't have ancestral inference in the pipelien) started with split and combined files.
BUT the problem is that the ancestral allele inference is not adopted to start from multiple chromosomes. We discussed that we will move the ancestral inference to after the merge (I've already started to work on this).

However, if you already have ancestral alleles file, you can test this on those files are here: "HighlanderLab/share/Snakemake/Data/RawVCF/TestChromosomeData"

@janaobsteter
Copy link
Collaborator

As mentioned, the ancestral allele inference will move as planned in #61

@hannesbecher
Copy link
Contributor Author

Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants