-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with Psycopg 3 #202
Conversation
I'm just having to work around this test: https://github.com/Hipo/drf-extra-fields/blob/master/tests/test_fields.py#L835 Basically, psycopg 3 will adjust the bounds to Any ideas on how to approach this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good!
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 93.98% 93.84% -0.15%
==========================================
Files 4 4
Lines 482 471 -11
==========================================
- Hits 453 442 -11
Misses 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @hartungstenio, we are really sorry for the late reply & review. Extra thanks for organizing imports and some styling.
It looks good overall but we prefer to not create a breaking change. I made comments regarding it. It would be nice if you update the PR according to these comments. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks again for this important patch.
This fixes the issue #190