fixed: stop spinner before prompt

Moddable SDK 5.3.3 is released without pre-built binaries. "xs-dev setup" requires the prompt, but it doesn't work in spinner working. #200 Reproduced on mac and linux. This change fixes the prompt.
HipsterBrown · Jan 1, 2025 · 6b85b9a · 6b85b9a
1 parent e970d77
commit 6b85b9a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/src/toolbox/setup/linux.ts b/src/toolbox/setup/linux.ts
@@ -76,6 +76,7 @@ export default async function ({
       const remoteRelease = await fetchRelease(release)
 
       if (remoteRelease.assets.length === 0) {
+        spinner.stop()
         print.warning(
           `Moddable release ${release} does not have any pre-built assets.`,
         )
@@ -90,6 +91,7 @@ export default async function ({
           )
           process.exit(0)
         }
+        spinner.start()
       }
 
       await system.spawn(

diff --git a/src/toolbox/setup/mac.ts b/src/toolbox/setup/mac.ts
@@ -80,6 +80,7 @@ export default async function ({
         const remoteRelease = await fetchRelease(release)
 
         if (remoteRelease.assets.length === 0) {
+          spinner.stop()
           print.warning(
             `Moddable release ${release} does not have any pre-built assets.`,
           )
@@ -94,6 +95,7 @@ export default async function ({
             )
             process.exit(0)
           }
+          spinner.start()
         }
 
         await system.spawn(

diff --git a/src/toolbox/setup/windows.ts b/src/toolbox/setup/windows.ts
@@ -223,6 +223,7 @@ export default async function ({
         const remoteRelease = await fetchRelease(release)
 
         if (remoteRelease.assets.length === 0) {
+          spinner.stop()
           print.warning(
             `Moddable release ${release} does not have any pre-built assets.`,
           )
@@ -237,6 +238,7 @@ export default async function ({
             )
             process.exit(0)
           }
+          spinner.start()
         }
 
         await system.spawn(