Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use kebab-case command flags, loosen device target typing for build/run commands #196

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

HipsterBrown
Copy link
Owner

@HipsterBrown HipsterBrown commented Dec 22, 2024

Discovered a few regressions from the refactor to use Strcli while building a few projects with xs-dev recently:

  • the multi-word command flags, such as --list-examples or target-branch, were accidentally changed to camelCase from the original kebab-case
  • the --device flag for the build / run / clean / debug commands was made an enum to match the setup command, however it should accept the "sub-target" device specifiers, i.e. esp32/s3, as well

Both of these are resolved in this PR. I opted for making the --device flag just a string argument instead of expanding the enum of values to reduce complexity of trying to fetch all the available options before building the command object and exploding the generated help text.

📦 Published PR as canary version: 0.33.5--canary.196.7f057a9.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@HipsterBrown HipsterBrown merged commit 8f47ef2 into main Dec 22, 2024
3 checks passed
@HipsterBrown HipsterBrown deleted the flags-spelling branch December 22, 2024 20:48
Copy link
Contributor

🚀 PR was released in v0.33.5 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant