fix(setup,update): build SDK tools if not included in tagged release #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HipsterBrown
commented
Dec 28, 2024
| port.manufacturer?.includes('Raspberry Pi') === true && | ||
| hasPicotool | ||
| ) { | ||
| if (port.vendorId === '2e8a' && hasPicotool) { |
There was a problem hiding this comment.
Updated this logic use the vendorId listed here: https://github.com/raspberrypi/usb-pid?tab=readme-ov-file#assignment
This should make matching more reliable, however it still doesn't solve for devices running MicroPython (which I was running into for one of my Pico boards). Not sure if I should try to solve for that edge case since it would require installing extra Python tools to reset the device into bootloader mode for getting info about the device.
|
🚀 PR was released in |
kitazaki
added a commit
to kitazaki/xs-dev
that referenced
this pull request
Jan 1, 2025
Moddable SDK 5.3.3 is released without pre-built binaries. "xs-dev setup" requires the prompt, but it doesn't work in spinner working. HipsterBrown#200 Reproduced on mac and linux. This change fixes the prompt.
HipsterBrown
pushed a commit
that referenced
this pull request
Jan 1, 2025
Moddable SDK 5.3.3 is released without pre-built binaries. "xs-dev setup" requires the prompt, but it doesn't work in spinner working. #200 Reproduced on mac and linux. This change fixes the prompt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding support for installing & updating the Moddable SDK from a specific tagged release version in #197, I was still running into the need for building the tooling (mcconfig, mcpack, simulator, etc) when not included in the release assets. This PR adds support for that workflow after confirming with the user.
Also included is a fix for updating the pico support by removing the unnecessary
git cloneof thepico-extrasrepo before fetching tags and pulling the required SDK branch.