-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shared checks for casks and formulae #17381
feat: add shared checks for casks and formulae #17381
Conversation
ebdc128
to
3d374a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me (once 🟢)! Thanks @SMillerDev.
3d374a7
to
7107d37
Compare
34bb892
to
c75f358
Compare
Next stop: url/head checks |
c75f358
to
26a821f
Compare
For some reason after this the checks don't actually run anymore: /o/homebrew (feat/cops/shared_homepage_cop|✔) $ brew style --fix homebrew/core --debug --verbose
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.1/bin/bundle clean No idea how to debug that problem though. |
I don't know why, sorry. Perhaps @issyl0 can help?
Stick |
This looks to be fixed by #17482. I checked out this branch locally, rebased it, and your |
26a821f
to
bbd73a7
Compare
Should be fine once those PRs are merged and we re-run the check. Thanks for the help @samford ! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This should make sure that the issues in the linux-fonts tap are fixed in the casks as well. It just doesn't work yet.