Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shared checks for casks and formulae #17381

Merged

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should make sure that the issues in the linux-fonts tap are fixed in the casks as well. It just doesn't work yet.

@SMillerDev SMillerDev force-pushed the feat/cops/shared_homepage_cop branch from ebdc128 to 3d374a7 Compare May 28, 2024 09:06
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me (once 🟢)! Thanks @SMillerDev.

@SMillerDev SMillerDev force-pushed the feat/cops/shared_homepage_cop branch from 3d374a7 to 7107d37 Compare May 28, 2024 13:09
@SMillerDev SMillerDev marked this pull request as ready for review May 28, 2024 13:09
@SMillerDev SMillerDev force-pushed the feat/cops/shared_homepage_cop branch 2 times, most recently from 34bb892 to c75f358 Compare May 28, 2024 13:43
@SMillerDev
Copy link
Member Author

Next stop: url/head checks

@SMillerDev SMillerDev force-pushed the feat/cops/shared_homepage_cop branch from c75f358 to 26a821f Compare May 28, 2024 14:08
@SMillerDev
Copy link
Member Author

For some reason after this the checks don't actually run anymore:

/o/homebrew (feat/cops/shared_homepage_cop|✔) $ brew style --fix homebrew/core --debug --verbose
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.1/bin/bundle clean

No idea how to debug that problem though.

@MikeMcQuaid
Copy link
Member

For some reason after this the checks don't actually run anymore:

I don't know why, sorry. Perhaps @issyl0 can help?

No idea how to debug that problem though.

Stick puts and raise all over the place and/or run rubocop in debug mode.

@samford
Copy link
Member

samford commented Jun 16, 2024

For some reason after this the checks don't actually run anymore

This looks to be fixed by #17482. I checked out this branch locally, rebased it, and your brew style command above works as expected.

@SMillerDev
Copy link
Member Author

Should be fine once those PRs are merged and we re-run the check. Thanks for the help @samford !

@SMillerDev SMillerDev merged commit e8430b2 into Homebrew:master Jun 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants