sorbet: Migrate dev-cmd files from typed: true to typed: strict

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Part of Use Sorbet typed: strict in all (non-package) files in Homebrew organisation #17297.

---

Draft because I'm not quite done yet (dev-cmd/bottle is being annoyingly fiddly) and I need to do a self-review of this PR to catch any little things I missed.

• There's lots of T.must here. I could probably do better with returning early or otherwise handling nils.
• There's quite a lot of T.untyped that I could think more about? Some of them are auto-fixed signatures that I need to go and tighten up.

[MikeMcQuaid]

• There's lots of T.must here. I could probably do better with returning early or otherwise handling nils.

Yes. T.must is kind of a smell to be avoided. Best bet is typically:

• assign to a variable (as Sorbet never assumes that calling the same function twice will get the same result)
• check the variable is nil and return/raise/etc. if so
• Use the variable after this time without needing T.must

• There's quite a lot of T.untyped that I could think more about?

I think T.untyped is OK as a Hash value if it cannot be otherwise represented with a single type (e.g. String, Symbol, etc.) because it stores multiple different types. All other cases: it should be avoided.

[MikeMcQuaid]

Nice work so far @issyl0! May be worth splitting this up even smaller to make review easier but don't feel strongly either way.

[issyl0]

Yes. T.must is kind of a smell to be avoided.

Yeah, coming back to this is why it's still draft!

[issyl0]

Alright, there's many fewer T.musts here now, in fact, zero! And I removed some pre-existing ones! ❤️

[MikeMcQuaid]

Thanks @issyl0, great work!

Think it'd be good to get rid of some of the T.nilable and T.untyped when possible later but: this is better than the status quo for sure. There's also some returns(NilClass) that should probably be void. All this can be done in follow-ups. Thanks again!