Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-upload: fix --warn-on-upload-failure functionality #19074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Jan 11, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

To reproduce: brew pr-upload --no-commit --warn-on-upload-failure in a directory with a few bottles where at least one is already uploaded to GitHub Packages.

For bottle uploads that would be skipped due to preupload_check warning about skipped uploads and returning early, the old code errored out due to JSON schema validation failure since the upload was allowed to resume:

"error"=>"value at /manifests/0/annotations/org.opencontainers.image.ref.name is not a string"

This change ensures that the upload is actually skipped if preupload_check returns no result.

For bottle uploads that would be skipped due to preupload_check warning about
skipped uploads and returning early, the old code errored out due to JSON schema
validation failure since the upload was allowed to resume:

    "error"=>"value at /manifests/0/annotations/org.opencontainers.image.ref.name is not a string"

This change ensures that the upload is effectively skipped if preupload_check
returns no result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant