pr-upload: fix --warn-on-upload-failure
functionality
#19074
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?To reproduce:
brew pr-upload --no-commit --warn-on-upload-failure
in a directory with a few bottles where at least one is already uploaded to GitHub Packages.For bottle uploads that would be skipped due to preupload_check warning about skipped uploads and returning early, the old code errored out due to JSON schema validation failure since the upload was allowed to resume:
This change ensures that the upload is actually skipped if preupload_check returns no result.