Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some stdlib gems from RBI generation #19075

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jan 11, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I propose excluding stdlib gems whose rbi files are already provided by sorbet: https://github.com/sorbet/sorbet/tree/master/rbi/stdlib

This saves some git bloat, and the sorbet versions are mostly better (they often include stricter type definitions, though AFAIK they are not automatically updated when new gem versions are released).

@@ -1,940 +0,0 @@
# typed: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was being marked false anyway, presumably due to conflicts with the sorbet version. (Might be worth finding the diff and upstreaming any fix, if someone feels motivated…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant