Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cask for Final Fantasy XIV #106950

Merged
merged 5 commits into from
Jul 4, 2021
Merged

Add cask for Final Fantasy XIV #106950

merged 5 commits into from
Jul 4, 2021

Conversation

stevestreza
Copy link
Contributor

@stevestreza stevestreza commented Jun 9, 2021

Adds the critically acclaimed MMORPG FINAL FANTASY XIV that has a free trial up to level 60 including the Heavensward expansion.

Reviewers: Please be advised if testing this cask, the downloaded DMG is approximately 2.5 GB.

  • It's unclear if I'm using the version tag correctly here, as I don't think this version string is actually the version of the installer, but the audit tool wouldn't accept with an unversioned URL that would also allow SHA256 verification, and I erred on the side of favoring security, but I could also disable this with :no_check and go with a more semantic version.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@miccal
Copy link
Member

miccal commented Jun 10, 2021

exception while auditing final-fantasy-xiv: Invalid argument @ io_fread - /private/tmp/20210609-2949-1spku3h

I believe this has something to do with large file sizes, but I am not sure.

@stevestreza
Copy link
Contributor Author

stevestreza commented Jun 10, 2021

I believe this has something to do with large file sizes, but I am not sure.

Yeah, looking around I see a few reports of this error with similarly large files. The downloaded DMG is over INT32_MAX bytes. This might be a bug in brew itself, or one of its dependencies. I can't reproduce it here, unfortunately, but I'm on macOS 11, not 10.15 like this test runner is.

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jul 2, 2021
@stevestreza
Copy link
Contributor Author

After looking at #107214 which suggests the build check issue is intermittent, I think the check that failed is now passing.

As a safety, I reran every command from the checklist above, including deleting the cached DMG and redownloading it. Every step worked as expected.

@miccal
Copy link
Member

miccal commented Jul 4, 2021

Thank you @stevestreza.

@miccal miccal merged commit bc7d90d into Homebrew:master Jul 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip new cask outdated stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants