marginnote 4.1.4 #185753
Open
marginnote 4.1.4 #185753
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade Marginnote4.14
khipp
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Thank you for your first contribution to homebrew-cask, @foreverangelwing! 🎉
There are still a few minor issues to address:
We should continue using interpolation for the version rather than hardcoding it in other stanzas. The placeholder #{version.major} will be replaced by the major version (e.g., 4) during evaluation.
Please also squash your commits to maintain a cleaner history.
| @@ -1,22 +1,22 @@ | |||
| cask "marginnote" do | |||
| version "3.7.25" | |||
| sha256 "4409e29b6046fc71442f3f2085375dada87b3f06a90892b2334823b0dad75ad3" | |||
| version "4.14" | |||
There was a problem hiding this comment.
Suggested change
| version "4.14" | |
| version "4.1.4" |
|
|
||
| url "https://marginstudy.com/mac/MarginNote#{version.major}.dmg", | ||
| verified: "marginstudy.com/mac/" | ||
| url "https://d.marginnote.cn/MarginNote4.dmg", |
There was a problem hiding this comment.
Suggested change
| url "https://d.marginnote.cn/MarginNote4.dmg", | |
| url "https://dist.marginnote.cn/MarginNote#{version}.dmg", |
| name "MarginNote" | ||
| desc "E-reader" | ||
| homepage "https://www.marginnote.com/" | ||
|
|
||
| livecheck do | ||
| url "https://dist.marginnote.cn/marginnote#{version.major}.xml" | ||
| url "https://dist.marginnote.cn/marginnote4.xml" |
There was a problem hiding this comment.
Suggested change
| url "https://dist.marginnote.cn/marginnote4.xml" | |
| url "https://dist.marginnote.cn/marginnote#{version.major}.xml" |
| strategy :sparkle, &:short_version | ||
| end | ||
|
|
||
| auto_updates true | ||
| depends_on macos: ">= :sierra" | ||
| depends_on macos: ">= :sequoia" |
There was a problem hiding this comment.
Suggested change
| depends_on macos: ">= :sequoia" | |
| depends_on macos: ">= :monterey" |
|
|
||
| app "MarginNote #{version.major}.app" | ||
| app "MarginNote 4.app" |
There was a problem hiding this comment.
Suggested change
| app "MarginNote 4.app" | |
| app "MarginNote #{version.major}.app" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the Homebrew Cask for MarginNote from version 3.7.25 to version 4.14.
Changes:
versionto4.14urltohttps://d.marginnote.cn/MarginNote4.dmgapptarget toMarginNote 4.appsha256to the new checksum for the updated dmg filelivecheckURL tohttps://dist.marginnote.cn/marginnote4.xmlReason for the Update:
MarginNote has released version 4.14 with new features and improvements. This update reflects the latest available version to ensure users can download and use the most current release.
Let me know if further modifications or corrections are needed. Thanks for reviewing!