Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.32.1 #160668

Merged
merged 2 commits into from
Jan 23, 2024
Merged

dolt 1.32.1 #160668

merged 2 commits into from
Jan 23, 2024

Conversation

Porkepix
Copy link
Contributor

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

go-mysql-server

  • 2279: fix count distinct with decimals
    Swapped out the library used in the CountDistinct aggregation function, as it would hash decimals to the same value.
    Correctness: test dolthub/dolt#7374
  • 2278: RangeHeapJoin should consistently sort NULL values before non-NULL values while managing its heap.
    Fixes Unexpected Results when Using BETWEEN AND after CREATE INDEX dolthub/dolt#7260
    This was ultimately caused by Internal comparisons consider NULL values higher than non-NULL values dolthub/go-mysql-server#1903. I didn't think it was possible for that issue to cause user-facing problems, but I was wrong. Because of that issue, RangeHeapJoins considered all NULL values in its children iterators to come after all non-NULL values. However, if the child node was an index, then the child iterator would order its rows with the NULL values first. This causes the RangeHeapIterator to mismanage the heap and skip rows that should have been in the results.
    I updated the range heap code to manually check for NULL values when manipulating the heap. I also updated the plan tests to include NULL values in the test tables, which should now catch this issue.
  • 2274: Fixup index selection when prefix not complete
    Consider a query SELECT * from t where b = 1 and c = 1 and two indexes, (a,b,c) and (b,c). We want to use the (b,c) index as a lookup, because (a,b,c) will be disjoint on a (b,c) key. This PR fixes index costing to record and prefer non-zero prefix matches. We only differentiate zero and non-zero cases here because it is easier and I think pretty reliable.
  • 2247: Merge joins populate join stats
    When merge joins are a join operator for a memo group, use the two indexes in the merge to estimate the join cardinality. Small updates so that join cardinality estimates work in the coster. A few tests that make use of join statistics. The tests are affected both by stat estimates and costing methodology. It's a bit hard to separate the two, since more accurate stat estimates so often identify issues with costing. The join statistic tests are subject to shifting based on whether the smallest table is estimated to be smaller than the smallest join cardinality estimate. Better tests would be less subject to noise. Tests for avoiding anti-patterns for specific join operators would also be useful.

Closed Issues

  • 7043: dolt clone can include extraneous remote refs
  • 7375: new tags not automatically being pushed to remote for remote primary
  • 7260: Unexpected Results when Using BETWEEN AND after CREATE INDEX
  • 7348: Add "Alter User" and "Set Password" SQL Statements

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jan 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 23, 2024
@BrewTestBot BrewTestBot enabled auto-merge January 23, 2024 01:14
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Homebrew:master with commit 3876b08 Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants