Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
MySQL index names are case-insensitive, but Dolt's index implementation wasn't handling them that way. This makes index names case-insensitive.
Customer issue: Dolt panics when renaming index containing capital letters dolthub/dolt#7945
New enginetests added in GMS PR: Bug Fix: Index name case-insensitivity dolthub/go-mysql-server#2530
Add the ability to run some dolt commands directly from the dolt sql shell.
Fixes: Embed cli command in
dolt sql
dolthub/dolt#6874TPS comparison is inverted compared t latency_p95 comparison.
go-mysql-server
IfConditional
s when applying stored proceduresWhen applying a stored procedure to a
CALL
statement, we weren't callingfinalizeSubqueries()
on any subqueries inIfConditional
expressions, which caused the subquery to not have aNodeExecBuilder
populated.Customer issue: Dolt panics on subquery in IF statement in procedure dolthub/dolt#7944
The
decimal.MarshalJSONWithoutQuotes
is a global variable.By setting this value then this can cause problems with any other code that does not expect this value to be changed.
Instead using a custom encoder to ensure that the marshalling behaviour is as expected without changing the global value ensure that this will not cause compatibility issues with other projects.
This code is covered both by existing tests, and an additional one in this PR.
(if the custom encode switch case is not added, but the global variables are, then the tests fail).
@@max_binlog_size
system variablehttps://dev.mysql.com/doc/refman/8.0/en/replication-options-binary-log.html#sysvar_max_binlog_size
Only run an "on update" code block when expressions are non-nil. Directly compare sql mode default string, rather than lowercasing every time.
vitess
BinlogStream
type intoBinlogMetadata
The
mysql.BinlogStream
type from Vitess was a little awkward to use, and seems to have been mostly intended as test code. This gives it a more descriptive name and makes it a little easier to pass around struct copies without concurrency issues from a shared instance.The
CREATE USER ... IDENTIFIED WITH
syntax (MySQL ref) allows the caching plugin to be specified in string quotes, but our parser only supported identifier quotes.This came up as part of binlog replication testing – MySQL was sending a
CREATE USER
statement from the primary to a Dolt replica, but Dolt wasn't able to parse the statement because of the use of string quotes around the caching plugin name.Closed Issues
dolt sql