Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Ensure heartbeat events sent from a Dolt primary to a MySQL replica have the latest nextLogPosition populated, otherwise the MySQL replica will close the binlog event stream.
add pg_views table to pg_catalog and views displayed on \d psql cmd dolthub/doltgresql#454 depends on this PR.
This PR fixes
dolthub/dolt-sql-server
image doesnt work correctly when regular dolt commands are supplied to it as arguments dolthub/dolt#8079. Now when runningdolthub/dolt-sql-server
if the argsdolt sql-server
are passed to the image, it will error. This will also prevent accidentally starting two Dolt servers in the container.This PR fixes two issues with creating secondary indexes for Doltgres types. The first deals with handlers, as we were not adding a
nil
handler for the additional hash type, which would cause a panic as the counts were not equal (all non-Extended types should have a matching nil handler).The second issue was due to the reuse of an
ExtendedTupleComparator
. When creating a newExtendedTupleComparator
, we pass in the previousTupleTypeHandler
to handle all non-Extended types. If the previousTupleTypeHandler
wasExtendedTupleComparator
and the new one was alsoExtendedTupleComparator
, then we could end up with a misinterpretation of data that could lead to incorrect results, as the handler assumed a different type than the actual type. This has been changed so thatExtendedTupleComparator
will always use the inner comparator of a previousExtendedTupleComparator
. For now this will always be the default comparator, but if we ever add another one, then this should properly handle that change.The initial impl of archive indexes over optimized for space. This resulted in being 10x slower to load the index of archives than noms table files. To address this:
Testing indicates that on a 41 Gb archive file, this returned load performance to match classic table files, and the size of the index increased by about 350Mb (total ~ 1Gb)
We observe dolthubapi can crash with the following nil pointer error:
Bumps golang.org/x/image from 0.10.0 to 0.18.0.
Commits
3bbf4a6
tiff: Validate palette indices when parsing palette-color images6c5fa46
go.mod: update golang.org/x dependencies55c4ab6
go.mod: update golang.org/x dependencies0057a93
tiff: fix function name in comment9e190ae
webp: disallow multiple VP8X chunks445ab0e
go.mod: update golang.org/x dependencies240a51a
font/sfnt: support early version 0 OS/2 tablesc20bbc3
draw: simplify some calls to fmt.Fprintf491771c
draw: merge draw_go117.go into draw.go4aa0222
go.mod: update go directive to 1.18[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/image&package-manager=go_modules&previous-version=0.10.0&new-version=0.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dolthub/dolt/network/alerts).
In Doltgres, whenever we would create an index, we would use the empty schema as the destination (the default value for the schema name). This meant that the updated table with an index was saved into the empty schema, which is incorrect since Doltgres always has a schema. This adds the schema to index creation, along with several other locations that it should be in.
go-mysql-server
Merging buckets in the current format is unsafe:
invalid bucket type: *stats.Bucket
at the end of the indexscan when adding the filtered histogram with a synthetic back to the implementor-type statisticEdited
mergeOverlappingBuckets
to not share memory, but also I'm not sure if merging buckets is a common performance win in most cases, so disabling for nowThe jsonpath module returns an error when performing a lookup with an out-of-bounds array index. We need to capture that error and return nil for the lookup operation instead.
unix_timestamp
builds off of: fix: add checking precision to decide sql types & handling limit unix timestamp date dolthub/go-mysql-server#2573
table_catalog
forinformation_schema.tables
vitess
Closed Issues
dolthub/dolt-sql-server
image doesnt work correctly when regular dolt commands are supplied to it as arguments