Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
I missed a test case in
nonCovLaxSecondaryLookupGen
. I tried to add more tests surrounding the specific panic query here: [no-release-notes] more join tests dolthub/go-mysql-server#2607.Also rename the
rowexec
tokvexec
.Major changes:
sqlengine
toserver
, so that bin logging only happens when insql-server
mode.binlogProducer
now sends events to the newlogManager
type that writes binlog events to files on disk.binlogStreamer
now reads events from those logs and streams them to replicas (instead of receiving events directly frombinlogProducer
).DoltBinlogPrimaryController
now validates that the missing GTIDs from a replica are available in the binlog files and sends an error if the primary doesn't have enough binlog data on disk to get a replica in sync.go-mysql-server
Self-join stats estimation is particularly expensive because all of the buckets exactly overlap. If the index is unique, the cardinality distribution will not change. If the index is non-unique, the cardinality will expand proportional to
rowCount/distinctCount
.vitess
ComPrepare
Currently, preparing multi-statements is not supported; so we can't prepare a query like
select ?; select ?;
.However, the check for this condition just looked for any characters after the first
;
, which meant that queries likeselect ?; \n
would incorrectly throw an error.This was made apparent using the Prisma ORM, which runs the query:
The fix is to use
SplitStatementToPieces()
, which trims these white space characters, and check if there's exactly one piece; this was taken from the vitessio repo: https://github.com/vitessio/vitess/blob/main/go/mysql/conn.go#L1204fixes Error when using Prisma ORM: "Error: unknown error: can not prepare multiple statements" dolthub/dolt#8157
PURGE BINARY LOGS
syntaxhttps://dev.mysql.com/doc/refman/8.4/en/purge-binary-logs.html
COM_BINLOG_DUMP_GTID
A MySQL primary needs to be able to send back an error response when handling the
COM_BINLOG_DUMP_GTID
command. Previously, when the integrator returned an error, it was logged in the primary server logs, but it was not being sent back to the replica who sent the command. This change causes an error packet to be sent to the replica, containing the details of the error the integrator returned.This change is difficult to test in isolation, but I have tests in
dolt
that will exercise this codepath.Closed Issues