Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huexpress: add workaround for newer clang and gcc 10+ #189595

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 13, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  In file included from src/engine/h6280.c:8:
  src/engine/dis_runtime.h:544:3: error: incompatible function pointer types initializing 'int (*)(void)' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
    544 |         {handle_bios, AM_IMPL, "???"}
        |          ^~~~~~~~~~~
  1 error generated.
  scons: *** [src/engine/h6280.o] Error 1

@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles sequoia-bottling labels Sep 13, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Sep 14, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 15, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 15, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 15, 2024
@chenrui333 chenrui333 changed the title huexpress: add patch to build with newer clang huexpress: add workaround for newer clang and gcc 10+ Sep 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 16, 2024
Merged via the queue into master with commit 3110190 Sep 16, 2024
22 checks passed
@BrewTestBot BrewTestBot deleted the huexpress-sequoia branch September 16, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. ready to merge PR can be merged once CI is green sequoia-bottling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants