Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigen: build an :all bottle #191250

Merged
merged 2 commits into from
Sep 19, 2024
Merged

eigen: build an :all bottle #191250

merged 2 commits into from
Sep 19, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 19, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Building new bottles should be sufficient to make this into an :all
bottle again.

While we're here, let's use more modern CMake syntax.

@carlocab
eigen: build an :all bottle
7425648 
Build new bottles should be sufficient to make this into an `:all`
bottle again.

While we're here, let's use more modern CMake syntax.
@carlocab
Copy link
Member Author

All checksums match ✅

b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1
b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1
b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1
b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1
b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1
b7d3fc4023e664e69392994530a88aa0b6f2a81067da6d64727cf983db2c1bd1

@carlocab carlocab marked this pull request as ready for review September 19, 2024 18:25
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 19, 2024
@carlocab carlocab added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 3668223 Sep 19, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the eigen-all branch September 19, 2024 19:33
@carlocab carlocab mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-dependents Pass --skip-dependents to brew test-bot. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlocab @chenrui333 @p-linnane @BrewTestBot