Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
fixes: Log metrics calls to
eventsapi.dolthub.com
in the Dolt server logs at appropriate log levels dolthub/dolt#8443go-mysql-server
This PR fixes an issue where foreign keys referencing the same column would fail to update the parent table (only on GMS).
Turns out we were adding the updater in the chain under the parent table's name instead of the child's name.
Additionally, has some small refactoring to tidy up the foreign key chain code.
fixes: setting two foreign keys to associate with the same field, deleting data is normal but does not take effect dolthub/go-mysql-server#2671
Minor changes to support Support for using
TEXT
fields in secondary indexes andUNIQUE
constraints dolthub/doltgresql#829Changes:
IsType()
methods now account for system variable types,create table from select ...
statements account for system variable typesNote: MySQL lists
@@admin_port
as Integer in their docs, but shows up asUInteger
in the CLIfixes: Incorrect type inference for
COALESCE
of system variables dolthub/dolt#8448Properly display defaults for views.
Also fixes defaults for views with filters.
fixes: ERROR: 1105 (HY000): handler caught panic: UnresolvedColumnDefault is a placeholder node, but Type() was called dolthub/dolt#8447
This PR cleans up the logic surrounding warnings and clearing them.
The important part was separating the number of "new" warnings from the list of warnings themselves.
Every query should clear out the warnings from the previous query. The exception is
show warnings
, which only clears the "count" of warnings.When a server runs a query that produces a warning, it immediately calls
show warnings
. Since theshow warnings
query itself should NOT clear the warnings, the warning count would always be > 0, and incorrectly indicate thatshow warnings
produced a warning. This causes an infinite loop in.NET
. Now, we always clear the warning count, and only clear the warnings themselves when the query is notshow warnings
.We've also had this weird problem of having to double clear warnings, which this should address.
fixes:
vitess
This PR adds syntax support for quoted character set values.
fix: quoted character set value is not supported dolthub/dolt#8455
Replace union type with one interface type. Static type access in reducer stack become runt-time interface conversions. The compiler builder loses the ability to do type checking at build time, so type safety has to be checked with testing.
Additional type enforcements are needed for nil-safety. Nil return values have to be typed correctly in the interface variable for casts up the stack to pass. Interface types do not have default nil values, so I've added
tryCastXXX
helper functions to accommodate untyped nils.Closed Issues
COALESCE
of system variableseventsapi.dolthub.com
in the Dolt server logs at appropriate log levels