Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-annex: readd S3 support. #60667

Closed
wants to merge 4 commits into from
Closed

git-annex: readd S3 support. #60667

wants to merge 4 commits into from

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Sep 4, 2020

Fixes #60505

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This readds the package settings lost in #59330.

I didn't readd the using: ["alex", "happy", "c2hs"], part because I couldn't figure out how; it means, "build this package with these tools". It sounds like something that cabal v2 already specifies implicitly? I'm not really sure. Anyway the package builds and works for me without them.

@BrewTestBot BrewTestBot added haskell Haskell use is a significant feature of the PR or issue missing license Formula has a missing license which should be added labels Sep 4, 2020
@kousu kousu changed the title git-annex: enable S3 support. git-annex: readd S3 and webapp support. Sep 4, 2020
@kousu kousu changed the title git-annex: readd S3 and webapp support. git-annex: readd S3 support. Sep 4, 2020
@kousu
Copy link
Contributor Author

kousu commented Sep 4, 2020

There are a lot of other flags that could be enabled too. This only addresses #60505; if you look in my report, you'll see that the difference was that "dependency versions" lost "aws-0.22".

The older version was enabling "S3" and "webapp"; it seems that webapp is on by default now, and I don't know what the --constraints were for but they don't seem to be necessary anymore: https://github.com/Homebrew/homebrew-core/pull/59330/files

@kousu kousu marked this pull request as ready for review September 4, 2020 22:55
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Sep 4, 2020
@kousu
Copy link
Contributor Author

kousu commented Sep 4, 2020

Failing because icon-license isn't in https://spdx.org/licenses/. Here's what git-annex's COPYRIGHT says about it:

Files: doc/logo* */favicon.ico standalone/osx/git-annex.app/Contents/Resources/git-annex.icns
Copyright: 2007 Henrik Nyh <http://henrik.nyh.se/>
           2010 Joey Hess <[email protected]>
           2013 John Lawrence
License: icon-license
  Free to modify and redistribute with due credit, and obviously free to use.

Thoughts on how to handle this? It's pretty similar to CC-BY but it's not CC-BY.

The same problem got supervisor nixed a couple weeks ago: #59948 (comment). I really hope that doesn't happen here because of a technicality. We're building a large scientific system (https://www.datalad.org/, https://openneuro.org, https://portal.conp.ca) on the back of git-annex.

@kousu
Copy link
Contributor Author

kousu commented Sep 5, 2020

If the ambiguous license is a problem, I have a from my bud @singpolyma to replace the icons with https://thenounproject.com/, or just patch them out of the package and let things break. I figure they're probably mostly used in the Assistant and the Webapp, and those should (should) be able to handle not having icons. But maybe they can't.

@SMillerDev
Copy link
Member

I'd say for usability it would be good to keep the icons, so making a patch to use open source ones would be great.

@kousu
Copy link
Contributor Author

kousu commented Sep 5, 2020 via email

These were extracted from COPYRIGHT in git://git-annex.branchable.com/
The text of icon-license in the git-annex source code is

Files: doc/logo* */favicon.ico standalone/osx/git-annex.app/Contents/Resources/git-annex.icns
Copyright: 2007 Henrik Nyh <http://henrik.nyh.se/>
           2010 Joey Hess <[email protected]>
           2013 John Lawrence
License: icon-license
  Free to modify and redistribute with due credit, and obviously free to use.

this seems libre to me, but it's not on the SPDX list.
To get my patch past the Homebrew linter, drop it.
@SMillerDev SMillerDev requested a review from a team September 6, 2020 06:51
@jonchang
Copy link
Contributor

jonchang commented Sep 7, 2020

Since COPYRIGHT is distributed in the bottle, and we don't include the documentation anyway we don't need to worry about the icon license.

Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kousu thanks for contributing to Homebrew!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haskell Haskell use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-annex lost Amazon S3 support
4 participants