git-annex: readd S3 support.

[kousu]

Fixes #60505

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This readds the package settings lost in #59330.

I didn't readd the using: ["alex", "happy", "c2hs"], part because I couldn't figure out how; it means, "build this package with these tools". It sounds like something that cabal v2 already specifies implicitly? I'm not really sure. Anyway the package builds and works for me without them.

[kousu]

There are a lot of other flags that could be enabled too. This only addresses #60505; if you look in my report, you'll see that the difference was that "dependency versions" lost "aws-0.22".

The older version was enabling "S3" and "webapp"; it seems that webapp is on by default now, and I don't know what the --constraints were for but they don't seem to be necessary anymore: https://github.com/Homebrew/homebrew-core/pull/59330/files

[kousu]

Failing because icon-license isn't in https://spdx.org/licenses/. Here's what git-annex's COPYRIGHT says about it:

Files: doc/logo* */favicon.ico standalone/osx/git-annex.app/Contents/Resources/git-annex.icns
Copyright: 2007 Henrik Nyh <http://henrik.nyh.se/>
           2010 Joey Hess <[email protected]>
           2013 John Lawrence
License: icon-license
  Free to modify and redistribute with due credit, and obviously free to use.

Thoughts on how to handle this? It's pretty similar to CC-BY but it's not CC-BY.

The same problem got supervisor nixed a couple weeks ago: #59948 (comment). I really hope that doesn't happen here because of a technicality. We're building a large scientific system (https://www.datalad.org/, https://openneuro.org, https://portal.conp.ca) on the back of git-annex.

[kousu]

If the ambiguous license is a problem, I have a from my bud @singpolyma to replace the icons with https://thenounproject.com/, or just patch them out of the package and let things break. I figure they're probably mostly used in the Assistant and the Webapp, and those should (should) be able to handle not having icons. But maybe they can't.

[SMillerDev]

I'd say for usability it would be good to keep the icons, so making a patch to use open source ones would be great.

[kousu]

The license is libre, it's just not on SPDX's list. Patching all the icons is kinda out of scope for what I was originally trying to fix. Is there a way to get this in and deal with the license later? I could just remove "icons-license" from the list, or is there a close-enough option on the SPDX list that we could relabel it as?

[jonchang]

Since COPYRIGHT is distributed in the bottle, and we don't include the documentation anyway we don't need to worry about the icon license.

[jonchang]

@kousu thanks for contributing to Homebrew!

[BrewTestBot]

🤖 A scheduled task has triggered a merge.