ceres-solver 2.0.0 #63596

NikolausDemmel · 2020-10-28T11:30:31Z

Created with brew bump-formula-pr.

dtrodrigues · 2020-10-31T16:39:06Z

opencv, opencv@3, and rawtoaces need revision bumps.

Should cmake instead be a build-only dependency?

NikolausDemmel · 2020-10-31T17:00:12Z

This also needs some more changes to the formula due to changes in how ceres handles dependencies. I have locally had success to build the ceres formula, but I'm stuck with the dependent formulas:

opencv, opencv@3, and rawtoaces need revision bumps.

Yes. These don't build with the latest release ceres, in fact. They might need small changes in cmake. But the bigger issue is that ceres 2.0.0 now requires C++14, and opencv 4 is built in C++11 mode, opencv@3 in C++99 mode. It is possible to build these formulas with C++14 with small changes, but it's untested and it might affect users (there may be binary incompatibility between c++99 and c++11, I guess).

I see the following alternatives:

Wait for upstream to become compatible with ceres 2.0. For opencv 3 and 4 I would guess it will never happen, b/c of C++11. I guess it will take forever until they are phased out. For rawtoaces we would have to see (didn't investigate yet if someone raised this upstream with rawtoaces yet).
Remove the formula dependencies, in particular from the opencv formulas. In the current release it's only an optional dependency of the sfm contrib (and a known issue w.r.t. ceres 2.0). Not sure how many would be affected by not having these optional parts of the sfm contrib available from the opencv formula. Moreover, it looks like ceres recently got added additionally as a dependency to the rgbd contrib, but w.r.t. to this issue they said that the best "fix" would be to remove the ceres dependency alltogether from the rgbd contrib.
Introduce a versioned formula ceres-solver@1, but after reading the documentation on that, I'm not sure if it qualifies in terms of popularity stats. Moreover, I don't think the ceres maintainers have plans to maintain the 1.14 branch separately (but version 1.14. was released in March 2018, so it has been stable for a long time).

Any suggestions which way to go here?

Should cmake instead be a build-only dependency?

I think so.

jonchang · 2020-11-02T13:52:58Z

Wait for upstream to become compatible with ceres 2.0. For opencv 3 and 4 I would guess it will never happen, b/c of C++11. I guess it will take forever until they are phased out.

I'd say that this justifies including an ceres-solver@1 formula, given that it is a dependency of the quite popular opencv which (correct me if I'm wrong) is still being maintained. Presumably the opencv maintainers would fix any problems in their own repo if there were issues with ceres-solver 1.14.

alalek

This is no issue to bump C++ version for OpenCV binaries if platforms used with Homebrew support that (it is compiler limitation only).
Bumping C++ version in user applications is not required, but we need to ensure "std" ABI compatibility during C++98 => C++11 change on HomeBrew supported platforms (std::string/std::vector/std::shared_ptr are used in OpenCV ABI).

alalek · 2020-11-02T12:04:50Z

Formula/opencv.rb

@@ -120,7 +123,7 @@ def install
        return 0;
      }
    EOS
-    system ENV.cxx, "-std=c++11", "test.cpp", "-I#{include}/opencv4",
+    system ENV.cxx, "-std=c++14", "test.cpp", "-I#{include}/opencv4",


No need to bump C++ version for User applications.
It is not necessary with modern compilers (last known incompatibility was with GCC 5.x, C++98/C++11 and _GLIBCXX_USE_CXX11_ABI macro).

(BTW, this test.cpp doesn't use OpenCV binaries, like .so/.dylib)

Yeah, makes sense, thanks. With your upstream changes in opencv I probably don't have to change anything about the formula here.

BrewTestBot · 2020-11-26T16:17:33Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

NikolausDemmel · 2020-11-27T10:49:48Z

I'd say that this justifies including an ceres-solver@1 formula, given that it is a dependency of the quite popular opencv which (correct me if I'm wrong) is still being maintained. Presumably the opencv maintainers would fix any problems in their own repo if there were issues with ceres-solver 1.14.

Sorry, I've been very busy at work lately. Thanks for you assessment, that is great, but even better would be if we can actually fix the depending formulas to use ceres 2.0. It looks much more likely than I originally thought:

There was some movement at opencv to make the contrib modules using ceres compatible with version 2.0. I'm not sure when the next release will be though. Possibly in a few months. In the meantime we could consider including the patch in homebrew already, if we wanna move forward with ceres 2.0. (Would have to check if it applies cleanly on the last releases open opencv).

I'll ping the rawtoaces author about ceres 2.0 compatibility.

Update: AcademySoftwareFoundation/rawtoaces#121

SeekingMeaning · 2020-12-14T21:55:33Z

If rawtoaces still isn't compatible when the new opencv releases come out, I think we should disable (or deprecate) it with :does_not_build as the reason. The latest (and only) release was released 3 years ago, and there hasn't been much activity in the GitHub repository other than two PR merges that modified their README.

jonchang · 2020-12-15T04:29:16Z

Yeah, I have a pull request open with them since august that hasn't been looked at. So probably we should just disable it.

SeekingMeaning · 2020-12-23T10:21:52Z

opencv - #67482
opencv@3 - #67515

NikolausDemmel · 2021-01-08T10:42:15Z

Ok, with the upstream changes in opencv no more formula changes seem to be required. Any C++14 requirements seem to be propagated by cmake for the corresponding code parts that depend on ceres. @SeekingMeaning disabled rawtoaces (there hasn't been any reaction upstream) and I squashed the commits, so I think it's ready for review.

SeekingMeaning · 2021-01-08T18:54:28Z

% brew linkage ceres-solver
System libraries:
  /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate
  /usr/lib/libSystem.B.dylib
  /usr/lib/libc++.1.dylib
Homebrew libraries:
  /usr/local/opt/gflags/lib/libgflags.2.2.dylib (gflags)
  /usr/local/opt/glog/lib/libglog.0.dylib (glog)
  /usr/local/opt/metis/lib/libmetis.dylib (metis)
  /usr/local/opt/openblas/lib/libopenblas.0.dylib (openblas)
  /usr/local/opt/suite-sparse/lib/libamd.2.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libcamd.2.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libccolamd.2.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libcholmod.3.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libcolamd.2.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libcxsparse.3.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libspqr.2.dylib (suite-sparse)
  /usr/local/opt/suite-sparse/lib/libsuitesparseconfig.5.dylib (suite-sparse)
  /usr/local/opt/tbb/lib/libtbb.dylib (tbb)
Indirect dependencies with linkage:
  metis
  openblas
  tbb
Dependencies with no linkage:
  eigen

SeekingMeaning · 2021-01-08T19:02:54Z

-DTBB=OFF was added in 7f34377 to avoid opportunistic linkage, and suite-sparse at the time did not depend on tbb (This is no longer the case as of 5195792)

Formula/ceres-solver.rb

NikolausDemmel · 2021-01-09T11:20:42Z

@SeekingMeaning: Oh, sorry, I didn't realize you wanted the commits split by file. Thanks for fixing it.

-DTBB=OFF was added in 7f34377 to avoid opportunistic linkage, and suite-sparse at the time did not depend on tbb (This is no longer the case as of 5195792)

TBB was a direct dependency in ceres 1.14, but they removed support for it and now it is only polled in b/c it may be used indirectly by suite-sparse. The TBB cmake argument was removed in ceres.

http://ceres-solver.org/installation.html

SeekingMeaning · 2021-01-09T15:16:49Z

Yes, sorry for the misunderstanding—my comment was meant more for record-keeping (so we can refer back to this PR and see why this specific change was made)

BrewTestBot · 2021-01-09T16:46:31Z

🤖 A scheduled task has triggered a merge.

BrewTestBot added the missing license Formula has a missing license which should be added label Oct 28, 2020

NikolausDemmel marked this pull request as draft October 28, 2020 11:33

chenrui333 added the test failure CI fails while running the test-do block label Oct 31, 2020

NikolausDemmel force-pushed the bump-ceres-solver-2.0.0 branch from 0211029 to f31f742 Compare October 31, 2020 17:12

BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request and removed automerge-skip `brew pr-automerge` will skip this pull request missing license Formula has a missing license which should be added labels Oct 31, 2020

NikolausDemmel force-pushed the bump-ceres-solver-2.0.0 branch from 964a231 to 15e278a Compare October 31, 2020 17:37

NikolausDemmel mentioned this pull request Nov 2, 2020

cmake: support Ceres 2.0.0 opencv/opencv_contrib#2732

Merged

5 tasks

alalek reviewed Nov 2, 2020

View reviewed changes

BrewTestBot added stale No recent activity and removed stale No recent activity labels Nov 26, 2020

NikolausDemmel mentioned this pull request Nov 27, 2020

ceres 2.0.0 compatibility AcademySoftwareFoundation/rawtoaces#121

Open

SeekingMeaning dismissed a stale review via 05941f2 January 6, 2021 19:22

SeekingMeaning force-pushed the bump-ceres-solver-2.0.0 branch from 26c3510 to 05941f2 Compare January 6, 2021 19:22

NikolausDemmel force-pushed the bump-ceres-solver-2.0.0 branch 2 times, most recently from da2d273 to d438ffd Compare January 7, 2021 10:59

NikolausDemmel marked this pull request as ready for review January 7, 2021 11:00

dtrodrigues removed the test failure CI fails while running the test-do block label Jan 8, 2021

SeekingMeaning dismissed a stale review via 1468255 January 8, 2021 18:54

SeekingMeaning force-pushed the bump-ceres-solver-2.0.0 branch from d438ffd to 1468255 Compare January 8, 2021 18:54

BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 8, 2021

NikolausDemmel and others added 4 commits January 8, 2021 11:03

ceres-solver 2.0.0

c7dee0a

opencv: revision bump for ceres-solver

fdc05f6

opencv@3: revision bump for ceres-solver

9593f70

rawtoaces: disable

3b67eb7

SeekingMeaning force-pushed the bump-ceres-solver-2.0.0 branch from 1468255 to 3b67eb7 Compare January 8, 2021 19:04

NikolausDemmel commented Jan 9, 2021

View reviewed changes

Formula/ceres-solver.rb Show resolved Hide resolved

SeekingMeaning approved these changes Jan 9, 2021

View reviewed changes

BrewTestBot closed this in 25d36a1 Jan 9, 2021

NikolausDemmel deleted the bump-ceres-solver-2.0.0 branch January 9, 2021 16:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ceres-solver 2.0.0 #63596

ceres-solver 2.0.0 #63596

NikolausDemmel commented Oct 28, 2020

dtrodrigues commented Oct 31, 2020

NikolausDemmel commented Oct 31, 2020

jonchang commented Nov 2, 2020

alalek left a comment

alalek Nov 2, 2020

NikolausDemmel Nov 27, 2020

BrewTestBot commented Nov 26, 2020

NikolausDemmel commented Nov 27, 2020 •

edited

Loading

SeekingMeaning commented Dec 14, 2020 •

edited

Loading

jonchang commented Dec 15, 2020

SeekingMeaning commented Dec 23, 2020

NikolausDemmel commented Jan 8, 2021

SeekingMeaning commented Jan 8, 2021

SeekingMeaning commented Jan 8, 2021 •

edited

Loading

NikolausDemmel commented Jan 9, 2021

SeekingMeaning commented Jan 9, 2021

BrewTestBot commented Jan 9, 2021

ceres-solver 2.0.0 #63596

ceres-solver 2.0.0 #63596

Conversation

NikolausDemmel commented Oct 28, 2020

dtrodrigues commented Oct 31, 2020

NikolausDemmel commented Oct 31, 2020

jonchang commented Nov 2, 2020

alalek left a comment

Choose a reason for hiding this comment

alalek Nov 2, 2020

Choose a reason for hiding this comment

NikolausDemmel Nov 27, 2020

Choose a reason for hiding this comment

BrewTestBot commented Nov 26, 2020

NikolausDemmel commented Nov 27, 2020 • edited Loading

SeekingMeaning commented Dec 14, 2020 • edited Loading

jonchang commented Dec 15, 2020

SeekingMeaning commented Dec 23, 2020

NikolausDemmel commented Jan 8, 2021

SeekingMeaning commented Jan 8, 2021

SeekingMeaning commented Jan 8, 2021 • edited Loading

NikolausDemmel commented Jan 9, 2021

SeekingMeaning commented Jan 9, 2021

BrewTestBot commented Jan 9, 2021

NikolausDemmel commented Nov 27, 2020 •

edited

Loading

SeekingMeaning commented Dec 14, 2020 •

edited

Loading

SeekingMeaning commented Jan 8, 2021 •

edited

Loading