Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libffi: use std_configure_args #67402

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Related: #66965, Homebrew/brew#10047

@SeekingMeaning
Copy link
Contributor Author

SeekingMeaning commented Dec 22, 2020

11.0:

brew test --retry --verbose creduce
brew test --retry --verbose glyr
brew test --retry --verbose llvm
brew install pypy
brew install pypy3

10.15, 10.14:

brew test --retry --verbose glyr
==> Testing glyr
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201222-60498-s070ky.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/glyr.rb --verbose --retry
==> /usr/local/Cellar/glyr/1.0.10_1/bin/glyrc cover --no-download --artist Beatles --album "Please Please Me" -w stdout
- Artist   : beatles
- Album    : please please me
- Language : en
- Type     : cover

---- Triggering: musictree local coverartarchive 
#[00/01] Checking image-types: [- DLError: URL using bad/illegal format or missing URL [3]
- DLError: URL using bad/illegal format or missing URL [3]
- DLError: URL using bad/illegal format or missing URL [3]
- DLError: URL using bad/illegal format or missing URL [3]
- DLError: URL using bad/illegal format or missing URL [3]
- DLError: URL using bad/illegal format or missing URL [3]
!!!!!!] (-6 item(s) less)
---- Triggering: lastfm jamendo musicbrainz 
---- Triggering: slothradio lyricswiki discogs 
---- Triggering: rhapsody picsearch google 

@iMichka iMichka merged commit 92f5e82 into Homebrew:master Dec 22, 2020
@iMichka
Copy link
Member

iMichka commented Dec 22, 2020

Merged as this is almost only a syntax change. Tested locally and all is fine.

The other build failures are unrelated but concerning. Should we open a separate issue to keep track of these?

@SeekingMeaning
Copy link
Contributor Author

Most of the Big Sur failures are acknowledged in #65000; I'm not sure why llvm and glyr are failing

@iMichka
Copy link
Member

iMichka commented Dec 22, 2020

glyr is known too: #66450

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 22, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants