Set minimum HTTP version to 2.0 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
HotCakeX
commented
Jan 4, 2025
HotCakeX
commented
- Set the minimum HTTP version to 2.0 so it no longer uses 1.1 as fallback and by default it tries the highest available version which is 3.0 at the moment.
- Enabled a new code analyzer: nested types should not be visible.
- Changed the update page's cache mode from enabled to required.
Set minimum HTTP version to 2.0. Enabled a new code analyzer: nested types should not be visible. Changed the update page's cache mode from enabled to required.
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- AppControl Manager/.editorconfig: Language not supported
- AppControl Manager/Pages/ViewFileCertificates.xaml.cs: Evaluated as low risk
- AppControl Manager/Logic/Main/BasePolicyCreator.cs: Evaluated as low risk
- AppControl Manager/Logic/AppUpdate.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
AppControl Manager/Logic/FileCertificateInfoCol.cs:5
- The comment should be capitalized: 'A class that represents each certificate in a chain'.
// a class that represents each certificate in a chain
AppControl Manager/Logic/FileCertificateInfoCol.cs:7
- [nitpick] The class name 'FileCertificateInfoCol' is not very descriptive. Consider renaming it to 'FileCertificateInfo'.
public sealed class FileCertificateInfoCol
HotCakeX
deleted the
Enforced-minimum-HTTP-version,-enabled-a-code-analyzer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.