Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented another protection when removing signed policies in AppControl Manager #522

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

HotCakeX
Copy link
Owner

This new protection mechanism ensures the safe removal of signed policies. To complete the process securely, a system reboot is required after the first stage. The newly implemented protection verifies that the reboot has been performed before allowing the process to proceed to the final stage.

If the user forgets to reboot or is unsure whether it’s necessary, a prompt will appear to guide them through the process. This safeguard prevents accidental errors that could lead to boot failures, making the AppControl Manager even safer and more reliable when managing Signed App Control policies.

Wonder why Signed policies are important? Check out this article


This new protection mechanism ensures the safe removal of signed policies. To complete the process securely, a system reboot is required after the first stage. The newly implemented protection verifies that the reboot has been performed before allowing the process to proceed to the final stage.

If the user forgets to reboot or is unsure whether it’s necessary, a prompt will appear to guide them through the process. This safeguard prevents accidental errors that could lead to boot failures, making the AppControl Manager even safer and more reliable when managing Signed App Control policies.
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 12, 2025
@HotCakeX HotCakeX self-assigned this Jan 12, 2025
@Copilot Copilot bot review requested due to automatic review settings January 12, 2025 20:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

AppControl Manager/Pages/SystemInformation/ViewCurrentPolicies.xaml.cs:708

  • The calculation for 'lastRebootTimeUtc' might be incorrect if 'Environment.TickCount64' overflows. Handle this case to avoid potential issues.
DateTime lastRebootTimeUtc = DateTime.UtcNow - TimeSpan.FromMilliseconds(Environment.TickCount64);

AppControl Manager/Logic/Main/UserConfiguration.cs:391

  • The use of '[]' for initializing the dictionary is incorrect in C#. It should be 'new Dictionary<string, DateTime>()'.
currentConfig.SignedPolicyStage1RemovalTimes ??= [];

@HotCakeX HotCakeX merged commit d2d773a into main Jan 13, 2025
2 checks passed
@HotCakeX HotCakeX deleted the Implemented-another-protection-around-signed-policies branch January 13, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant